Patch #21245

UI/CSS refinements, part 1

Added by Daniel Ritz almost 2 years ago. Updated almost 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:-

Description

A few patches for UI/CSS that allow better/easier styling in themes.

  • Patches 0001 and 0002:
    Replaces all uses of image_tag() to render icons with icon-* definitions. This makes is possible to replace all these icons with Font-based icons, e.g. FontAwesome.
  • Patch 0003:
    A unimportant change to use the PDF icon for "Also available in PDF" links
  • Patch 0004:
    Updates pagination to use <ul> and <li> to render the pagination part
  • Patch 0005:
    Building on top of patch 0004, changes pagination to a GitHub like design that also looks and feels nice in responsive mode

Based on r14881, everything passes "rake test" and is tested in Firefox 42, Safari 9 and Chrome 46.

More to come :)

0001-Replace-uses-of-image_tag-with-CSS-part-1-admin.patch Magnifier (22.7 KB) Daniel Ritz, 2015-11-16 21:31

0002-Replace-uses-of-image_tag-with-CSS-part-2.patch Magnifier (22.4 KB) Daniel Ritz, 2015-11-16 21:31

0003-Use-PDF-icon-for-Also-available-in-PDF.patch Magnifier (1002 Bytes) Daniel Ritz, 2015-11-16 21:31

0004-Pagination-use-ul-to-do-pagination-for-better-stylin.patch Magnifier (12.7 KB) Daniel Ritz, 2015-11-16 21:31

0005-Pagination-change-to-a-GitHub-like-style.patch Magnifier (1.72 KB) Daniel Ritz, 2015-11-16 21:31


Related issues

Duplicates Redmine - Patch #21256: Use CSS instead of image_tag() to show icons for better t... Closed
Duplicates Redmine - Patch #21257: Use PDF icon for "Also available in PDF" New
Duplicates Redmine - Patch #21258: Use <ul> to do pagination, styling in a GitHub like manne... Closed

History

#2 Updated by Toshi MARUYAMA almost 2 years ago

  • Status changed from New to Needs feedback

Could you separate patches to new issues?
It seems three group [1, 2], [3], [4, 5].

#3 Updated by Daniel Ritz almost 2 years ago

Done:
  • 1,2: #21256. I folded the two patches into one and also corrected accidental duplicated CSS rules.
  • 3: #21257. Same as here.
  • 4,5: #21258. With minor correction in positioning, plus screen shot included.

#4 Updated by Go MAEDA almost 2 years ago

  • Status changed from Needs feedback to Closed

Thanks for creating issues.

#5 Updated by Go MAEDA almost 2 years ago

  • Duplicates Patch #21256: Use CSS instead of image_tag() to show icons for better theming support added

#6 Updated by Go MAEDA almost 2 years ago

  • Duplicates Patch #21257: Use PDF icon for "Also available in PDF" added

#7 Updated by Go MAEDA almost 2 years ago

  • Duplicates Patch #21258: Use <ul> to do pagination, styling in a GitHub like manner with improved handling in responsive mode added

Also available in: Atom PDF