Patch #21611

Do not collect ids of subtree in Query#project_statement

Added by Ondřej Ezr over 2 years ago. Updated over 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Code cleanup/refactoring
Target version:3.3.0

Description

It is inefficient in larger subtree - it would be nicer with pluck, but it would still result in ugly queries with more projects.
Best way is to use subquery in that cases

query_project_statement.diff Magnifier - use query not pluck ids (1.41 KB) Ondřej Ezr, 2015-12-27 19:07

query_project_statement_2.diff Magnifier - v2 (1.5 KB) Ondřej Ezr, 2016-01-03 19:45


Related issues

Related to Redmine - Defect #19976: Redmine can't work with 3000 projects Needs feedback
Related to Redmine - Feature #19102: Redmine doesnt scale with large amount of projects Needs feedback

Associated revisions

Revision 15135
Added by Jean-Philippe Lang over 2 years ago

Query project_statement - do not collect ids of subtree (#21611).

Patch by Ondřej Ezr.

History

#1 Updated by Go MAEDA over 2 years ago

  • Target version set to Candidate for next major release

According to #21608#note-3, this patch will resolve #19976 and #19102.

#2 Updated by Go MAEDA over 2 years ago

  • Related to Defect #19976: Redmine can't work with 3000 projects added

#3 Updated by Go MAEDA over 2 years ago

  • Related to Feature #19102: Redmine doesnt scale with large amount of projects added

#4 Updated by Jean-Philippe Lang over 2 years ago

The patch breaks a few tests. It displays issues from subpprojects even if display_subprojects_issues setting is disabled.

#5 Updated by Ondřej Ezr over 2 years ago

I see... I frogot one case in the statement.

#6 Updated by Go MAEDA over 2 years ago

Thanks for updating the patch. It have passed all tests.

#7 Updated by Toshi MARUYAMA over 2 years ago

  • Target version changed from Candidate for next major release to 3.3.0

#8 Updated by Jean-Philippe Lang over 2 years ago

  • Subject changed from Query project_statement - do not collect ids of subtree. to Do not collect ids of subtree in Query#project_statement
  • Category set to Code cleanup/refactoring
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed, thanks!

Also available in: Atom PDF