Project

General

Profile

Actions

Defect #22335

closed

Images with non-ASCII file names are not shown in PDF

Added by Go MAEDA over 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
PDF export
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Images with non-ASCII file names are not shown in PDF. Please see the following image. There are two embedded image "shrine.jpg" and "神社.jpg" in a issue description. But "神社.jpg" (an image with non-ASCII file name) are not shown in exported PDF.


Files

issue-export-sample.pdf (113 KB) issue-export-sample.pdf PDF with problem Go MAEDA, 2016-03-29 06:53
defect-description.jpg (70.4 KB) defect-description.jpg Go MAEDA, 2016-03-29 07:24
cherryblossoms.png (36.4 KB) cherryblossoms.png Kuniharu AKAHANE, 2016-07-14 06:15
cherry blossoms.png (36.4 KB) cherry blossoms.png Kuniharu AKAHANE, 2016-07-14 06:15
exported_pdf.png (68.3 KB) exported_pdf.png Kuniharu AKAHANE, 2016-07-14 06:56
browser_view.png (155 KB) browser_view.png Kuniharu AKAHANE, 2016-07-14 06:56
22335-with-rfpdf-1.19.1.pdf (275 KB) 22335-with-rfpdf-1.19.1.pdf Go MAEDA, 2017-03-30 04:52
Actions #1

Updated by Kuniharu AKAHANE over 8 years ago

Hi, Go Maeda.
Thanks for reporting this issue here.
I reproduced this issue on our site.

Just for your information,

Not only images with non-ASCII file names but also with ASCII file names which includes special characters are not shown in PDF.
I guess url-encoding or url-handling of file-path cause this issue. (somewhere in rbpdf ?)

Examples:

# cherryblossoms.png
!cherryblossoms.png!
# cherry blossoms.png  (include space character, not shown )
!cherry blossoms.png!
# cherry%20blossoms.png  (include space character with url encoded, shown in browser but not in PDF)
!cherry%20blossoms.png!

Show results

Show logs on our web-site

Repoduced Environment-1

Repoduced Environment-2

Actions #2

Updated by Kuniharu AKAHANE over 8 years ago

Opps, Add captured images.

Actions #3

Updated by Jun NAITOH over 7 years ago

This problem fixed by rbpdf 1.19.1.
please bundle update.

Actions #4

Updated by Kuniharu AKAHANE over 7 years ago

Thanks you very much for your time, naito-san.

I tried rbpdf 1.19.1 on our all redmine instanses.
The problem seems to be fixed so far.

Environment:

  Redmine version                3.3.2.stable
  Ruby version                   2.3.3-p222 (2016-11-21) [x86_64-linux]
  Rails version                  4.2.7.1
  Environment                    production
  Database adapter               Mysql2

bundle update results:

 Using rbpdf-font 1.19.1 (was 1.19.0)
 Using rbpdf 1.19.1 (was 1.19.0)

Actions #5

Updated by Go MAEDA over 7 years ago

I confirmed that images with a file name which contains non-ASCII and whitespace characters is rendered properly after updating to rfpdf 1.19.1 by executing bundle update.

22335-with-rfpdf-1.19.1.pdf

Thank you for working on this, Naitoh-san. We can close this issue.


Note for those who are in trouble with this problem:

Please run the following commands on your Redmine server.

cd /path/to/redmine
bundle update
Actions #6

Updated by Toshi MARUYAMA over 7 years ago

  • Target version set to 3.2.6
Actions #7

Updated by Toshi MARUYAMA over 7 years ago

  • Status changed from Closed to New
  • Target version changed from 3.2.6 to 3.4.0
  • Resolution deleted (Fixed)
Actions #8

Updated by Toshi MARUYAMA over 7 years ago

  • Blocked by Feature #25538: Drop support for Ruby 2.2.1 and ealier, 2.2.2+ is now required added
Actions #9

Updated by Jean-Philippe Lang over 7 years ago

  • Target version changed from 3.4.0 to 3.2.6
Actions #10

Updated by Toshi MARUYAMA over 7 years ago

  • Blocked by deleted (Feature #25538: Drop support for Ruby 2.2.1 and ealier, 2.2.2+ is now required)
Actions #11

Updated by Jean-Philippe Lang over 7 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Fixed with rbpdf 1.19.2.

Actions

Also available in: Atom PDF