Project

General

Profile

Actions
Copy link

Defect #22583

closed

CSV import delimiter detection broken

Added by Jan from Planio www.plan.io about 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Issues
Target version:
3.2.2
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:
3.2.1

Description

When uploading a CSV file to import, the delimiter used in the CSV is supposed to be auto-detected.

However, File.read seems to not be used properly: The third parameter may not be a string.

This is rescued in the block and therefore, the user does not see the error. However, the auto-detection does not work.

Attached is a simple patch that fixes this.

Files

fix_csv_autodetection.patch (484 Bytes) fix_csv_autodetection.patch Jan from Planio www.plan.io, 2016-04-19 16:38
Actions
Copy link
 #1

Updated by Go MAEDA almost 8 years ago

  • Status changed from Needs feedback to New
  • Target version changed from Candidate for next minor release to 3.2.2

Thanks for the patch. Setting target version to 3.2.2.

Actions
Copy link
 #2

Updated by Go MAEDA almost 8 years ago

  • Resolution deleted (Fixed)
Actions
Copy link
 #3

Updated by Jean-Philippe Lang almost 8 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Committed, thanks.

Actions
Copy link

Also available in: Atom PDF