Patch #23180

Make the issue id from email notifications linkable to issue page

Added by Marius BALTEANU 8 months ago. Updated 8 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Email notifications
Target version:3.3.1

Description

The attached patch adds to the "#issue_id" from the email notifications a link to the issue page. This link is very useful when you read the emails on the phone or small screens and you want to quickly open the issue page.

Currently, you need to scroll down until the end of the email to find the line with the issue subject (h1 element). Also, some email clients (like Inbox from Google) hide that content after first reply because it find it duplicated. I have attached some examples:
- inbox.png which contains a screenshot with the notification received from #7360 in Inbox. You can observe that in the respective screen, there is no link to the issue.
- office.png which an example from office 365 popup. Here I need to scroll down to find the issue.

With the attached patch you can easily open the issue page:

If you consider that this change should contains a test, please let me know.

I've added the link also on issue_add.html.erb only for consistency.

inbox.png (124 KB) Marius BALTEANU, 2016-06-27 18:17

office.png (73.5 KB) Marius BALTEANU, 2016-06-27 18:17

office_with_link.png (73.3 KB) Marius BALTEANU, 2016-06-27 18:20

link_to_issue.patch Magnifier (1.12 KB) Marius BALTEANU, 2016-06-27 18:35

Associated revisions

Revision 15587
Added by Jean-Philippe Lang 8 months ago

Make the issue id from email notifications linkable to issue page (#23180).

Patch by Marius BALTEANU.

Revision 15588
Added by Jean-Philippe Lang 8 months ago

Adds an assertion for this (#23180).

History

#1 Updated by Go MAEDA 8 months ago

  • Target version set to 3.4.0

Thanks for the improvement.
It works fine for me. Setting target version to 3.4.0.

#2 Updated by Jean-Philippe Lang 8 months ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version changed from 3.4.0 to 3.3.1

Patch committed, thanks.
I think we can add this change to 3.3.1.

#3 Updated by Jean-Philippe Lang 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF