Defect #24297

Show action not allowed for time entries in closed projects

Added by Felix Schäfer about 1 year ago. Updated about 1 year ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Permissions and roles
Target version:3.2.5
Resolution:Fixed Affected version:

Description

It is currently not possible to GET /time_entries/123.xml for closed projects even with the correct permissions.

In the TimelogController currently checks if the time entry is editable for the current user on show, edit and update. This means show doesn't work for closed projects as the time entry is then not editable.

24297.patch Magnifier (1.09 KB) Felix Schäfer, 2016-11-08 15:10

Associated revisions

Revision 15955
Added by Jean-Philippe Lang about 1 year ago

Show action not allowed for time entries in closed projects (#24297).

Patch by Felix Schäfer.

Revision 15956
Added by Jean-Philippe Lang about 1 year ago

Adds a test for #24297.

History

#1 Updated by Felix Schäfer about 1 year ago

The attached patch is a proposal to fix this problem.

#2 Updated by Jan from Planio www.plan.io about 1 year ago

  • Status changed from New to Confirmed
  • Target version set to Candidate for next minor release

#3 Updated by Jean-Philippe Lang about 1 year ago

  • Status changed from Confirmed to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version changed from Candidate for next minor release to 3.2.5
  • Resolution set to Fixed

Fix committed with a test, thanks.

#4 Updated by Jean-Philippe Lang about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF