Project

General

Profile

Actions

Defect #26072

closed

Set default assignee before validation

Added by Felix Schäfer almost 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Category:
Issues
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Currently the default assignee is set only after validations. This means that when the field is required the default assignee does not work.

The following patch changes setting the default assignee to before the validation:

diff --git a/app/models/issue.rb b/app/models/issue.rb
index 7d411fc94..a5ebfbffa 100644
--- a/app/models/issue.rb
+++ b/app/models/issue.rb
@@ -105,8 +105,8 @@ class Issue < ActiveRecord::Base
     end
   }

+  before_validation :default_assign, on: :create
   before_validation :clear_disabled_fields
-  before_create :default_assign
   before_save :close_duplicates, :update_done_ratio_from_issue_status,
               :force_updated_on_change, :update_closed_on, :set_assigned_to_was
   after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}

Files

26072-reproduce.png (56 KB) 26072-reproduce.png Go MAEDA, 2017-05-31 15:32

Related issues

Related to Redmine - Feature #482: Default assignee on each projectClosedJean-Philippe Lang

Actions
Related to Redmine - Feature #26680: Show default assignee when creating new issueNew

Actions
Actions #1

Updated by Go MAEDA almost 7 years ago

I can reproduce the problem as follows.
I confirmed that the problem is reproducible and can be fixed by the pasted patch.

Actions #2

Updated by Felix Schäfer almost 7 years ago

Thank you for confirming this.

Please be aware that this also affects the newly introduced project default assignee, i.e. if an assignee is required and the project has a default assignee the issue will not be created.

Maybe it would be better to make this more explicit by change the "assignee" field to the default project assignee on new issues, and by changing the assignee when changing the category if the assignee wasn't changed yet.

Actions #3

Updated by Go MAEDA almost 7 years ago

  • Related to Feature #482: Default assignee on each project added
Actions #4

Updated by Jean-Philippe Lang almost 7 years ago

  • Status changed from Confirmed to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Fix committed in r16619 with a test.

Felix Schäfer wrote:

Maybe it would be better to make this more explicit by change the "assignee" field to the default project assignee on new issues, and by changing the assignee when changing the category if the assignee wasn't changed yet.

Agreed, it would be an interesting improvement.

Actions #5

Updated by Jean-Philippe Lang almost 7 years ago

  • Status changed from Resolved to Closed
Actions #6

Updated by Toshi MARUYAMA over 6 years ago

  • Related to Feature #26680: Show default assignee when creating new issue added
Actions

Also available in: Atom PDF