Project

General

Profile

Actions
Copy link

Patch #26149

closed

Remove duplicate method shell_quote

Added by Jens Krämer over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Code cleanup/refactoring
Target version:
3.4.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

There are two identical methods shell_quote declared in Redmine::Utils::Shell and Redmine::Scm::Adapters::AbstractAdapter.

This patch removes the duplicate declaration from AbstractAdapter and also extracts a generic shell_quote_command method into Redmine::Utils::Shell.

Files

0001-removes-duplicate-shell_quote-method.patch (2.8 KB) 0001-removes-duplicate-shell_quote-method.patch Jens Krämer, 2017-06-13 08:36
Actions
Copy link
 #1

Updated by Go MAEDA over 7 years ago

  • Category changed from SCM to Code cleanup/refactoring
  • Target version set to 3.4.0

Jens Krämer wrote:

There are two identical methods shell_quote declared in Redmine::Utils::Shell and Redmine::Scm::Adapters::AbstractAdapter.

Indeed. Those two methods are completely identical. The patch looks good to me and passed all tests.
Setting target version to 3.4.0.

Actions
Copy link
 #2

Updated by Jean-Philippe Lang over 7 years ago

  • Subject changed from duplicate method shell_quote to Remove duplicate method shell_quote
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed, thanks!

Actions
Copy link

Also available in: Atom PDF