Actions
Patch #26157
closedRender all possible inline textile images
Start date:
Due date:
% Done:
0%
Estimated time:
Description
In r15433, Redmine introduced a security measure to restrict embedding images to only those with valid schemes from Textile.
Now, if there are multiple images referenced on a page, with only one of them invalid, Redmine currently doesn't create <img>
tags for any of them since it would return from the replacement method too soon.
This patch fixes this behavior in that it still allows to embed all valid images and only refuses to embed the invalid ones by skipping the rest of the current gsub
iteration instead of the whole method. The patch was extracted from Planio
Files
Updated by Go MAEDA over 7 years ago
- File 26157-expected.png 26157-expected.png added
- File 26157-actual.png 26157-actual.png added
- Target version set to 3.4.0
Confirmed the problem. Setting target version to 3.4.0.
Markup:
!http://www.cs.cmu.edu/~chuck/lennapg/len_std.jpg! !data:text/html;base64,iVBORw0KGgoAAAANSUhEUgAAAAgAAAAICAMAAADz0U65AAAABlBMVEX2Ojr///8SFd07AAAAEklEQVQI12Nk/A+FDFCakSwRAPZFHA3MVemHAAAAAElFTkSuQmCC!
Expected (with the patch applied):
Actual (without the patch):
Updated by Jean-Philippe Lang over 7 years ago
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
Committed, thanks!
Actions