Actions
Defect #26350
closedDon't display file download button while on repository directory entries
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
As the subject states, the file download button is also displayed on repository directory entries. This obviously shouldn't be the case.
This issue has been introduced with r16672 for #26035.
I'll attach a small patch fixing the issue. I've included the addition of a test assertion (for Git) showcasing the issue. I am not sure what is the best place to test this properly, so I've left multiple of such assertions out of the other adapters.
The patch, against source:/trunk@16749, is produced using git format-patch
which makes it apply-able using "patch -p1 < 0001-...
".
Environment:
Environment: Redmine version 3.4.0.devel@r16749 Ruby version 2.3.3-p222 (2016-11-21) [x86_64-linux] Rails version 4.2.8 Environment production Database adapter Mysql2 SCM: Subversion 1.8.8 Git 1.9.1 Filesystem Redmine plugins: no plugin installed
Files
Related issues
Updated by Mischa The Evil over 7 years ago
- Related to Feature #26035: More visually consistent download links added
Updated by Jean-Philippe Lang over 7 years ago
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Fix committed, thanks.
Actions