Feature #26035

More visually consistent download links

Added by Jan from Planio www.plan.io 2 months ago. Updated about 1 month ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI
Target version:3.4.0
Resolution:Fixed

Description

As a follow-up to #25988 and #25999, this small patch series proposes to move the file download link on previews to a more common place – the contextual area. It also introduces another link wihin the "No preview available" message to make it easier for users to download a file instead of previewing it.

Before:

After:

download_links_after.png (114 KB) Jan from Planio www.plan.io, 2017-05-24 18:50

download_links_before.png (108 KB) Jan from Planio www.plan.io, 2017-05-24 18:50

0001-Move-download-link-to-contextual-area.patch Magnifier (3.1 KB) Jan from Planio www.plan.io, 2017-05-24 18:51

0002-Add-download-link-to-no-preview-message.patch Magnifier (5.72 KB) Jan from Planio www.plan.io, 2017-05-24 18:51

0003-German-translation-for-download.patch Magnifier (945 Bytes) Jan from Planio www.plan.io, 2017-05-24 18:51


Related issues

Related to Redmine - Feature #25357: "Raw view" of a file in repository New
Related to Redmine - Defect #26350: Don't display file download button while on repository di... Closed
Blocked by Redmine - Feature #25999: View repository content by default (instead of the history) Closed

Associated revisions

Revision 16672
Added by Jean-Philippe Lang about 1 month ago

Move download link to contextual area (#26035).

Patch by Jan Schulz-Hofen.

Revision 16673
Added by Jean-Philippe Lang about 1 month ago

Add download link to no preview message (#26035).

Patch by Jan Schulz-Hofen.

Revision 16674
Added by Jean-Philippe Lang about 1 month ago

German translation for download (#26035).

Patch by Jan Schulz-Hofen.

Revision 16679
Added by Toshi MARUYAMA about 1 month ago

generate i18n keys (#26035)

History

#1 Updated by Go MAEDA 2 months ago

I think that the improvement is fairly useful but unfortunately the patch cannot be applied to the current trunk (r16559) cleanly. Could you tell me how can I apply them?

$ patch -p1 < 0001-Move-download-link-to-contextual-area.patch
patching file app/views/layouts/_file.html.erb
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file app/views/layouts/_file.html.erb.rej
patching file app/views/repositories/_link_to_functions.html.erb
Reversed (or previously applied) patch detected!  Assume -R? [n]

#2 Updated by Jan from Planio www.plan.io 2 months ago

Go MAEDA wrote:

I think that the improvement is fairly useful but unfortunately the patch cannot be applied to the current trunk (r16559) cleanly. Could you tell me how can I apply them?

I am sorry, I failed to mention that #25999 and therefore #25988 are required for this patch to apply cleanly.

#3 Updated by Jan from Planio www.plan.io 2 months ago

  • Blocked by Feature #25999: View repository content by default (instead of the history) added

#4 Updated by Go MAEDA 2 months ago

  • Target version changed from Candidate for next minor release to 3.4.0

Jan from Planio www.plan.io wrote:

I am sorry, I failed to mention that #25999 and therefore #25988 are required for this patch to apply cleanly.

Thanks, the patch works fine now.
This small patch makes #25988 and #25999 even better and I think it should be merged along with those issues. Setting target version to 3.4.0.

#5 Updated by Mischa The Evil about 1 month ago

#6 Updated by Mischa The Evil about 1 month ago

My two cents based on the screenshots:

Jan from Planio www.plan.io wrote:

[...] this small patch series proposes to move the file download link on previews to a more common place – the contextual area.

I'm not sure about this change. The current contextual area does not seem to be the best place for such a link (and an eventual 'raw' link as proposed in #25357). I kinda like the current (and #25999 's) link position (I'm aware of the fact this is really a matter of taste, which is a difficult thing design-wise...).

Jan from Planio www.plan.io wrote:

It also introduces another link wihin the "No preview available" message to make it easier for users to download a file instead of previewing it.

Nice one.

#7 Updated by Jean-Philippe Lang about 1 month ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Mischa The Evil wrote:

I'm not sure about this change. The current contextual area does not seem to be the best place for such a link (and an eventual 'raw' link as proposed in #25357). I kinda like the current (and #25999 's) link position (I'm aware of the fact this is really a matter of taste, which is a difficult thing design-wise...).

Yes, I was not sure as well but it seems better than the download link below the tabs after all. Patches are committed, thanks.

#8 Updated by Mischa The Evil 23 days ago

  • Related to Defect #26350: Don't display file download button while on repository directory entries added

Also available in: Atom PDF