Patch #26424

Avatar Spacing in Headlines

Added by Felix Gliesche 4 months ago. Updated 4 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI
Target version:3.4.2

Description

Currently the space between h2 and an avatar is not correct compared to the space between an avatar and a h3. You can see this problem in the news section. The headline of a news detail view is closer to the avatar than the headline to the avatar on the news index. This is due to a missing space. In addition to this discrepancy I have realized, that there is no need for negative margins for the avatar in h2, and h3 headlines. The only reason I do see for an avatar to have a negative margin within a headline is the case of a h4:

I am attaching a patch series, which a) adds a space between the avatar and the text for h2 headline and b) removes negative margins for avatar images within h2 and h3 headlines. The following images show the difference. Please note, that the difference due to b) is visible in the vertical space to the text after the headline. Because the negative margins are removed the flow is more natural as the baseline is not moved up by some pixels.

before after

h4.jpg (42.5 KB) Felix Gliesche, 2017-07-13 11:41

h3-after.png (42.5 KB) Felix Gliesche, 2017-07-13 11:41

h3-before.png (42.6 KB) Felix Gliesche, 2017-07-13 11:41

h2-after.png (49.9 KB) Felix Gliesche, 2017-07-13 11:41

h2-before.png (49.7 KB) Felix Gliesche, 2017-07-13 11:41

0001-Add-space-between-avatar-and-headline.patch Magnifier (849 Bytes) Felix Gliesche, 2017-07-13 11:43

0002-Remove-negative-margin-for-avatar-in-h2-and-h3.patch Magnifier (992 Bytes) Felix Gliesche, 2017-07-13 11:43

Associated revisions

Revision 16820
Added by Jean-Philippe Lang 4 months ago

Add space between avatar and headline (#26424).

Patch by Felix Gliesche.

Revision 16821
Added by Jean-Philippe Lang 4 months ago

Remove negative margin for avatar in h2 and h3 (#26424).

Patch by Felix Gliesche.

History

#1 Updated by Go MAEDA 4 months ago

  • Target version set to 3.4.2

#2 Updated by Jean-Philippe Lang 4 months ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Patches committed, thanks.

Also available in: Atom PDF