Patch #26492

% is not valid without a format specifier

Added by Pavel Rosický 4 months ago. Updated 4 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Roadmap
Target version:3.4.3

Description

roadmap overview raises ArgumentError: incomplete format specifier on ruby 2.5 dev

as suggested on https://bugs.ruby-lang.org/issues/13761 it should be prepended with another '%'

'%0.0f%' % 45 - wrong
'%0.0f%%' % 45 - correct

patch included

Environment:
  Redmine version                3.4.1.stable
  Ruby version                   2.5.0-p-1 (2017-07-21) [x86_64-linux]
  Rails version                  4.2.9
  Environment                    production
  Database adapter               PostgreSQL
SCM:
  Git                            2.13.0
  Filesystem

_overview.html.erb.patch Magnifier (1.07 KB) Pavel Rosický, 2017-07-21 11:40

Associated revisions

Revision 16841
Added by Jean-Philippe Lang 4 months ago

ArgumentError: incomplete format specifier on ruby 2.5 dev (#26492).

Patch by Pavel Rosický.

History

#1 Updated by Go MAEDA 4 months ago

  • Category set to Roadmap
  • Target version set to 3.4.3

Certainly "%%" is correct to display a percent sign itself in sprintf format string.
Setting target version to 3.4.3.

#2 Updated by Jean-Philippe Lang 4 months ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang

Patch committed, thanks.

#3 Updated by Jean-Philippe Lang 4 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF