Defect #26880
Cannot clear all watchers when copying an issue
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Jean-Philippe Lang | % Done: | 0% | |
| Category: | Issues | |||
| Target version: | 3.4.4 | |||
| Resolution: | Fixed | Affected version: | 3.4.2 |
Description
We can select/deselect watchers when we create an issue by copying existing issue (#10460).
But if you deselect all watchers, the original watchers are preselected in the newly created issue despite the exception that the copied issue has no watcher.
Steps to reproduce:
1. The original issue has 2 watchers.
2. Click "Copy" and deselect all watcher.
3. The newly created issue should not have any watchers but all watchers are preserved.
01-copy-source@2x.png (68.6 KB)
02-deselect-watchers@2x.png (52.3 KB)
03-watchers-are-preserved@2x.png (67.8 KB)
fix_26880.patch 
(2.08 KB)
Related issues
History
#1
Updated by Go MAEDA about 2 years ago
- Related to Feature #10460: Option to copy watchers when copying issues added
#2
Updated by Tibor Kreiter about 2 years ago
Hi Go MAEDA!
You have to change this row in app/controllers/issue_controller:
row:493 - @copy_watchers = User.current.allowed_to?(:add_issue_watchers, @project)
+ @copy_watchers = params[:copy_watchers].present? || request.get?
I think it will be solve your problem.
Tibor
#3
Updated by Toshi MARUYAMA about 2 years ago
- Status changed from New to Confirmed
- Target version set to 3.4.4
It seems caused by #10460.
#4
Updated by Takenori TAKAKI almost 2 years ago
- File fix_26880.patch added
I think the attached patch will solve this problem.
this patch compatible with latest trunk (r17055).
#5
Updated by Jean-Philippe Lang almost 2 years ago
- Status changed from Confirmed to Closed
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Fix applied with a slightly different solution.
Thanks for pointing this out.