Project

General

Profile

Actions
Copy link

Defect #3480

closed

Bot filter plugin crashes when missing useragent

Added by Brad Schick almost 15 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
2009-06-11
Due date:
% Done:

0%

Estimated time:
Resolution:
Affected version:

Description

Using the BotsFilterPlugin, I noticed exceptions when there was no useragent in a request. I applied the following patch to fix this. Note that this patch blocks requests with missing useragents as if they were bots.

Files

Download all files
bot_filter.patch (460 Bytes) bot_filter.patch Test for nil useragent Brad Schick, 2009-06-11 08:50
allow_empty_user_agent.patch (477 Bytes) allow_empty_user_agent.patch Jérémy Lal, 2010-06-18 00:36
Actions
Copy link
 #1

Updated by Jérémy Lal almost 14 years ago

  • Assignee changed from Eric Davis to Jean-Philippe Lang

I confirm that bug,
which BTW breaks rake tests.

Assigning to JP Lang since he's the one releasing botsfilter plugin.

Regards.

Actions
Copy link
 #2

Updated by Jérémy Lal almost 14 years ago

it's best to not filter requests if user_agent is blank.
See attached patch.

Actions
Copy link
 #3

Updated by Jean-Baptiste Barth almost 11 years ago

  • Category deleted (Plugin API)
  • Status changed from New to Closed
  • Assignee deleted (Jean-Philippe Lang)

Closing this issue: very old + it is about a specific plugin, the current policy is to report issues in the dedicated bug tracker of each plugin.

Actions
Copy link

Also available in: Atom PDF