Project

General

Profile

Actions

Patch #36807

closed

Remove CommonMark experimental flag and mark as deprecated the RedCarpet Markdown

Added by Marius BĂLTEANU over 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Text formatting
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Files

deprecations.png (278 KB) deprecations.png Marius BĂLTEANU, 2022-12-03 14:16

Related issues

Related to Redmine - Feature #32424: CommonMark Markdown Text FormattingClosedMarius BĂLTEANU

Actions
Related to Redmine - Feature #38372: Use Commonmarker instead of Redcarpet by default when rendering Markdown attachmentsClosedGo MAEDA

Actions
Blocks Redmine - Feature #34863: Change default text formatter for new installations from textile to common_markClosedMarius BĂLTEANU

Actions
Actions #1

Updated by Marius BĂLTEANU over 2 years ago

  • Related to Feature #32424: CommonMark Markdown Text Formatting added
Actions #2

Updated by Marius BĂLTEANU over 2 years ago

  • Target version changed from Candidate for next major release to 5.1.0
Actions #3

Updated by Go MAEDA over 2 years ago

  • Blocks Feature #34863: Change default text formatter for new installations from textile to common_mark added
Actions #4

Updated by Go MAEDA over 2 years ago

  • Category set to Text formatting
Actions #5

Updated by Holger Just over 2 years ago

For what it's worth, I'm in favor of

  • Removing the experimental flag on the common_mark formatter
  • Marking the previous markdown formatter as deprecated
  • Making the common_mark formatter the default for new installations #34863

The timeline of this may be stretched out a bit, but does not necessarily have to. The deprecation / experimental "flags" on the formatters do not change anything in terms of functionality and can be set in a 5.0.x patch release.

The default formatter is only relevant for new installations. I have no strong opinion on whether this requires a major release (6.0.0) or minor release (5.1.0). I have a slight hunch that it might be surprising in a patch release (5.0.x).

Actions #6

Updated by Marius BĂLTEANU over 2 years ago

I think we do all these changes in 5.1.0.

The experimental flag was already removed in r21594 and I will deprecate markdown right after we switch the default formatter to common_mark (#34863).

Actions #7

Updated by Marius BĂLTEANU about 2 years ago

  • Status changed from New to Resolved

I'va marked in r21898 the legacy Markdown as deprecated, but I think we should show this deprecation also in admin/info for those instances that are using this option.

What do you think?

Actions #8

Updated by Go MAEDA about 2 years ago

Marius BALTEANU wrote:

I'va marked in r21898 the legacy Markdown as deprecated, but I think we should show this deprecation also in admin/info for those instances that are using this option.

I agree. I think such a warning is helpful to encourage admins to migrate to CommonMark Markdown.

Actions #9

Updated by Marius BĂLTEANU almost 2 years ago

What do you think if we add a deprecation table to the Admin -> Info page?

Actions #10

Updated by Go MAEDA over 1 year ago

  • Related to Feature #38372: Use Commonmarker instead of Redcarpet by default when rendering Markdown attachments added
Actions #11

Updated by Go MAEDA about 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF