Project

General

Profile

Actions

Patch #40506

closed

Remove redundant ApplicationHelper inclusions

Added by Takuya Kodama about 2 months ago. Updated 19 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

ApplicationHelper has already been included in ActionView::TestCase. Although some test classes inherit from ActionView::TestCase, they include ApplicationHelper in their own classes again. Therefore, we don't need to include ApplicationHelper in those classes because it is already included.

For example, the ancestry of WikiFormatting::MacrosTest is as follows, and it includes ApplicationHelper in the WikiFormatting::MacrosTest class again.

  • WikiFormatting::MacrosTest < Redmine::HelperTest < ActionView::TestCase

Files

Actions

Also available in: Atom PDF