Defect #4682
Completed version with wrong progress bar status
| Status: | New | Start date: | 2010-01-28 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% |
|
| Category: | Roadmap | |||
| Target version: | Candidate for next minor release | |||
| Affected version: | 1.1.2 | Resolution: |
Description
I have a version inside a project which only contains 2 bugs/issues. Both of them were fixed and percentage of completement is both at 100%. Yet, as you can see in the screenshot, it shows 100% complete, but according to the progress bar 1 issue isn't closed yet. Which is actually.
I've tried setting the completement status to 90%, save, and set it back to a 100%. But no luck.
I've setup my Redmine instance to check the commit messages in my repository. When it says closes/fixes #<issue nr> it sets the status to resolved and at 100% ready/complete. This so far hasn't lead to any problems before.
roadmap-percentage-bug.PNG (15 kB)
wrong_completed_percent_computation_with_0_time_issues.patch
(4.1 kB)
wrong_completed_percent_computation_with_0_time_issues.patch - v2
(4.4 kB)
Related issues
History
#1 Updated by Christiaan Kras over 2 years ago
Some extra info.
The last issue I changed from resolved to closed also had an time estamate which I changed to 0 whilst closing the issue. Maybe something went wrong here?
#2 Updated by Christiaan Kras over 2 years ago
If a issue has the expected time set to 0.0 the earlier reported error happens. After removing it and saving the issue the problem is solved.
Seems to me that the part that calculates the progress should ignore issues with a expected time of 0.
#3 Updated by Etienne Massip about 1 year ago
- Target version set to Candidate for next minor release
- Affected version changed from 0.9.0 to 1.1.2
#4 Updated by Etienne Massip about 1 year ago
Here's a patch.
I believe there is a similar issue with done percent computation for a task with subtasks.
#5 Updated by Etienne Massip about 1 year ago
There is a very simpler patch which consists to add in Version#closed_pourcent the test
1... 2if open_issues_count == 0 3 100 4...
which already exists in
Version#completed_pourcent.#6 Updated by Etienne Massip about 1 year ago
Full patch with tests.
Basically there are two possible calculation (depending on whether there is a total time estimated), which was intended to be prevented in #2182.