Patch #5770

Welcome text misses wiki formatting

Added by Holger Just over 7 years ago. Updated over 2 years ago.

Status:ClosedStart date:2010-06-28
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Text formatting
Target version:3.1.0

Description

The attached patch surrounds the welcome text with a <div class="wiki"> to render the same as all the other info texts.

001_sorround_with_wiki_div.diff Magnifier (485 Bytes) Holger Just, 2010-06-28 19:05


Related issues

Related to Redmine - Patch #12031: welcome text in a div with class box Closed

Associated revisions

Revision 14448
Added by Jean-Philippe Lang over 2 years ago

Welcome text misses wiki div (#5770).

History

#1 Updated by Mikhail Sviridov over 7 years ago

Holger Just wrote:

The attached patch surrounds the welcome text with a <div class="wiki"> to render the same as all the other info texts.

#2 Updated by Mischa The Evil about 3 years ago

  • Related to Patch #12031: welcome text in a div with class box added

#3 Updated by Mischa The Evil about 3 years ago

This change fixes some issues with overlapping code boxes too.

A different approach is proposed in #12031. I prefer this simpler change though...

#4 Updated by Mischa The Evil over 2 years ago

  • Target version set to 3.1.0

Is this a patch that we can still target to 3.1.0? I don't know "how frozen" 3.1-stable is at the moment.
Nevertheless, I think this could be considered a defect, marking this (small) patch a candidate for a future >= 3.1.1 release anyway.

Mischa The Evil wrote:

A different approach is proposed in #12031. [...]

A second look at it shows me that it does more than adding a div alone - with the wrong class also, box does not fix the formatting issues that rise when a "pre" block and/or a "pre code" block is being used in the welcome text (wiki class does fix these) - and these changes were found unrelated/unwanted (#12031#note-2).
As such, I'd propose to close issue #12031 in favor of the patch proposed in this patch (which, I think, will also fix the issue that the OP of #12031 was intending to patch initially).

#5 Updated by Jean-Philippe Lang over 2 years ago

  • Category set to Text formatting
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Patch committed.

#6 Updated by Mischa The Evil over 2 years ago

Thanks!

Also available in: Atom PDF