Feature #6033
closed
Allow addition/removal of subtasks to show in parent's history
Added by Mark P over 13 years ago.
Updated over 2 years ago.
Description
The subtask feature has been working as expected. When I remove a parent from a child, that change is captured in the child's history, but it does not appear in the parent's history. I think it would be really handy to be able to see from the parent's perspective, how many child issues came and went. Seeing history like this viewing from the child up to the parent is a tad cumbersome. Hopefully, that makes sense.
Bravo Zulu on Redmine.
Files
Display the addition / deletion of subtask issues in the parent issue's history block.
I attached a patch.
- Target version set to Candidate for next major release
- Subject changed from Allow removal of child subtasks to show in parent's History block to Allow addition/removal of subtasks to show in parent's History block
- Target version changed from Candidate for next major release to 4.1.0
Setting the target version to 4.1.0.
- Target version changed from 4.1.0 to 4.2.0
- Target version changed from 4.2.0 to 5.0.0
Update the patch for the latest trunk (r21204).
The patch breaks an existing test. This is because patched Redmine sends an email notification when a journal that records the addition or removal of a subtask is added.
Error:
MailHandlerTest#test_add_issue_should_send_notification:
NameError: undefined local variable or method `byebug' for #<MailHandlerTest:0x00007fd3f69b1d98>
test/unit/mail_handler_test.rb:438:in `test_add_issue_should_send_notification'
rails test test/unit/mail_handler_test.rb:431
Go MAEDA wrote:
The patch breaks an existing test. This is because patched Redmine sends an email notification when a journal that records the addition or removal of a subtask is added.
[...]
I have confirmed that the test fails. I fixed test/unit/mail_handler_test.rb as follows.
diff --git a/test/unit/mail_handler_test.rb b/test/unit/mail_handler_test.rb
index 3fd3ce0722..999cb8ceac 100644
--- a/test/unit/mail_handler_test.rb
+++ b/test/unit/mail_handler_test.rb
@@ -433,10 +433,19 @@ class MailHandlerTest < ActiveSupport::TestCase
assert issue.is_a?(Issue)
assert !issue.new_record?
- mail = ActionMailer::Base.deliveries.last
- assert_not_nil mail
- assert mail.subject.include?("##{issue.id}")
- assert mail.subject.include?('New ticket on a given project')
+ assert_equal 4, issue.parent_issue_id
+ assert_equal 2, ActionMailer::Base.deliveries.size
+
+ [
+ [issue.id, 'New ticket on a given project'],
+ [4, 'Issue on project 2'],
+ ].each do |issue_id, issue_subject|
+ mail =
+ ActionMailer::Base.deliveries.detect do |m|
+ /##{issue_id}/.match?(m.subject) && /#{issue_subject}/.match?(m.subject)
+ end
+ assert_not_nil mail
+ end
end
def test_created_user_should_be_added_to_groups
- Subject changed from Allow addition/removal of subtasks to show in parent's History block to Allow addition/removal of subtasks to show in parent's history
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you for your contribution.
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by