Defect #7114

New gantt doesn't display some projects

Added by Jean-Baptiste Barth almost 7 years ago. Updated over 6 years ago.

Status:ClosedStart date:2010-12-15
Priority:LowDue date:
Assignee:Jean-Baptiste Barth% Done:

0%

Category:Gantt
Target version:1.2.0
Resolution:Fixed Affected version:

Description

With new gantt charts, subprojects for which parent project doesn't have issue_tracking enabled are not shown.

Explicit use case: I defined some root projects where I only enable gantt, calendar and news systems, and subprojects which map to real-world projects so they have issues, versions, documents, etc.

I have a working patch for that, but it's pretty inefficient:
  • either you display all projects (not desired behaviour I suppose?)
  • either you try to find if a project have descendants with issue_tracking enabled (respecting visibility...)

I'd welcome any suggestion to define what should be the desired behaviour and what are the potential extreme cases we don't want to handle.

show_projects_having_a_descendant_with_issue_tracking.patch Magnifier (8.1 KB) Jean-Philippe Lang, 2010-12-16 11:16


Related issues

Related to Redmine - Patch #7456: Gantt filters New 2011-01-26

History

#1 Updated by Mischa The Evil almost 7 years ago

Good catch! I'd vote +1 for your second solution, though it shouldn't introduce (more?) performance issues within such an implementation.

#2 Updated by Jean-Philippe Lang almost 7 years ago

The attached patch should fix it with option 2.

#3 Updated by Jean-Baptiste Barth almost 7 years ago

Still hard to use on a large project base : 100+ projects => "Completed in 24617ms", VS 1.6s for the test database. I had nearly the same results with my patch but it was less clean (I imagine parsing .descendants for each project costs a lot). I'll try to see if I can improve it.

#4 Updated by Jean-Baptiste Barth almost 7 years ago

OK, nothing to do with searching for .descendants in each project. I turned on development mode, I end up with some 922 queries to the database, maybe a bit too much ;) To be continued

#5 Updated by Jean-Philippe Lang almost 7 years ago

And I've already made a few optimizations on the initial implementation. It's still very slow and I think we'll have to make some compromises, like removing project/version completion calculation which generates a bunch of queries. Project completion is not calculated properly BTW.

#6 Updated by Jean-Philippe Lang over 6 years ago

  • Status changed from New to Closed
  • Target version set to 1.2.0
  • Resolution set to Fixed

Fixed in r5077.

Also available in: Atom PDF