Project

General

Profile

Patch #26604 ยป 0001-Add-a-randomized-name-attribute-to-all-form-fields.patch

Holger Just, 2017-08-01 19:26

View differences:

app/helpers/application_helper.rb
fields_for(*args, &proc)
end
def form_tag_html(html_options)
# Set a randomized name attribute on all form fields by default
# as a workaround to https://bugzilla.mozilla.org/show_bug.cgi?id=1279253
html_options['name'] ||= "#{html_options['id'] || 'form'}-#{SecureRandom.hex(4)}"
super
end
# Render the error messages for the given objects
def error_messages_for(*objects)
objects = objects.map {|o| o.is_a?(String) ? instance_variable_get("@#{o}") : o}.compact
test/helpers/application_helper_test.rb
assert_equal '<span class="hours hours-int">0</span><span class="hours hours-dec">:45</span>', html_hours('0:45')
assert_equal '<span class="hours hours-int">0</span><span class="hours hours-dec">.75</span>', html_hours('0.75')
end
def test_form_for_includes_name_attribute
assert_match(/name="new_issue-[a-z0-9]{8}"/, form_for(Issue.new){})
end
def test_labelled_form_for_includes_name_attribute
assert_match(/name="new_issue-[a-z0-9]{8}"/, labelled_form_for(Issue.new){})
end
end
    (1-1/1)