Project

General

Profile

Feature #17840 » 17840_notified_events_target_version.patch

Yuichi HARADA, 2019-10-04 02:45

View differences:

app/models/journal.rb
(Setting.notified_events.include?('issue_note_added') && notes.present?) ||
(Setting.notified_events.include?('issue_status_updated') && new_status.present?) ||
(Setting.notified_events.include?('issue_assigned_to_updated') && detail_for_attribute('assigned_to_id').present?) ||
(Setting.notified_events.include?('issue_priority_updated') && new_value_for('priority_id').present?)
(Setting.notified_events.include?('issue_priority_updated') && new_value_for('priority_id').present?) ||
(Setting.notified_events.include?('issue_fixed_version_updated') && detail_for_attribute('fixed_version_id').present?)
)
Mailer.deliver_issue_edit(self)
end
config/locales/en.yml
label_issue_status_updated: Status updated
label_issue_assigned_to_updated: Assignee updated
label_issue_priority_updated: Priority updated
label_issue_fixed_version_updated: Target version updated
label_document: Document
label_document_new: New document
label_document_plural: Documents
lib/redmine/notifiable.rb
notifications << Notifiable.new('issue_status_updated', 'issue_updated')
notifications << Notifiable.new('issue_assigned_to_updated', 'issue_updated')
notifications << Notifiable.new('issue_priority_updated', 'issue_updated')
notifications << Notifiable.new('issue_fixed_version_updated', 'issue_updated')
notifications << Notifiable.new('news_added')
notifications << Notifiable.new('news_comment_added')
notifications << Notifiable.new('document_added')
test/unit/journal_observer_test.rb
class JournalObserverTest < ActiveSupport::TestCase
fixtures :issues, :issue_statuses, :journals, :journal_details, :projects,
:projects_trackers, :trackers, :enabled_modules, :enumerations,
:users, :email_addresses, :roles, :members, :member_roles
:users, :user_preferences, :email_addresses, :roles, :members, :member_roles,
:versions
def setup
User.current = nil
ActionMailer::Base.deliveries.clear
@journal = Journal.find 1
end
# context: issue_updated notified_events
......
end
assert_equal 0, ActionMailer::Base.deliveries.size
end
def test_create_should_send_email_notification_with_issue_fixed_version_updated
with_settings :notified_events => %w(issue_fixed_version_updated) do
user = User.find_by_login('jsmith')
issue = issues(:issues_001)
issue.init_journal(user)
issue.fixed_version = versions(:versions_003)
assert issue.save
assert_equal 2, ActionMailer::Base.deliveries.size
end
end
def test_create_should_send_email_notification_without_issue_fixed_version_updated
with_settings :notified_events => [] do
user = User.find_by_login('jsmith')
issue = issues(:issues_001)
issue.init_journal(user)
issue.fixed_version = versions(:versions_003)
assert issue.save
assert_equal 0, ActionMailer::Base.deliveries.size
end
end
end
(2-2/3)