Project

General

Profile

Defect #32289 » 32289_not_thumbnailable_when_convert_unavailable.patch

Yuichi HARADA, 2019-10-28 08:58

View differences:

app/models/attachment.rb
end
def thumbnailable?
image? || (is_pdf? && Redmine::Thumbnail.gs_available?)
Redmine::Thumbnail.convert_available? && (
image? || (is_pdf? && Redmine::Thumbnail.gs_available?)
)
end
# Returns the full path the attachment thumbnail, or nil
test/unit/attachment_test.rb
assert_equal true, Attachment.new(:filename => 'test.jpg').thumbnailable?
end
def test_thumbnailable_should_be_true_for_non_images
def test_thumbnailable_should_be_false_for_images_without_convert_available
Redmine::Thumbnail.stubs(:convert_available?).returns(false)
assert_equal false, Attachment.new(:filename => 'test.jpg').thumbnailable?
end
def test_thumbnailable_should_be_false_for_non_images
assert_equal false, Attachment.new(:filename => 'test.txt').thumbnailable?
end
(2-2/3)