Project

General

Profile

Defect #35441 » 35441.patch

Yuichi HARADA, 2021-07-02 04:56

View differences:

lib/redmine/helpers/url.rb
return true unless uri.to_s.include? ":"
# Other URLs need to be parsed
schemes.include? URI.parse(uri).scheme
schemes.include? URI.parse(uri.split('?').first).scheme
rescue URI::Error
false
end
test/unit/lib/redmine/helpers/url_test.rb
assert uri_with_safe_scheme?("https://example.com/")
assert uri_with_safe_scheme?("ftp://example.com/index.html")
assert uri_with_safe_scheme?("mailto:root@example.com")
# Gravatar uri of admin@somenet.foo and parameters
assert uri_with_safe_scheme?("https://www.gravatar.com/avatar/982b6086063a22d85509455d8e31cca2?s=32&d=identicon&r=PG")
assert uri_with_safe_scheme?("https://www.gravatar.com/avatar/982b6086063a22d85509455d8e31cca2?s=32x%x%d=identiconx%x%r=PG")
end
def test_uri_with_safe_scheme_invalid_component
(2-2/3)