Project

General

Profile

Defect #35827 ยป 0001-Allow-to-delete-closed-and-archived-projects.patch

Holger Just, 2021-08-30 18:52

View differences:

app/controllers/projects_controller.rb
:except => [:index, :autocomplete, :list, :new, :create, :copy]
before_action :authorize,
:except => [:index, :autocomplete, :list, :new, :create, :copy,
:archive, :unarchive]
:archive, :unarchive,
:destroy
]
before_action :authorize_global, :only => [:new, :create]
before_action :require_admin, :only => [:copy, :archive, :unarchive]
accept_rss_auth :index
lib/redmine.rb
map.permission :add_project, {:projects => [:new, :create]}, :require => :loggedin
map.permission :edit_project, {:projects => [:settings, :edit, :update]}, :require => :member
map.permission :close_project, {:projects => [:close, :reopen]}, :require => :member, :read => true
map.permission :delete_project, {:projects => :destroy}, :require => :member
map.permission :delete_project, {:projects => :destroy}, :require => :member, :read => true
map.permission :select_project_modules, {:projects => :modules}, :require => :member
map.permission :view_members, {:members => [:index, :show]}, :public => true, :read => true
map.permission :manage_members, {:projects => :settings, :members => [:index, :show, :new, :create, :edit, :update, :destroy, :autocomplete]}, :require => :member
test/functional/projects_controller_test.rb
assert_nil Project.find_by_id(1)
end
def test_destroy_should_destroy_archived_project
set_tmp_attachments_directory
@request.session[:user_id] = 1 # admin
Project.find_by_id(2).update_attribute :status, Project::STATUS_ARCHIVED
assert_difference 'Project.count', -1 do
delete(
:destroy,
:params => {
:id => 2,
:confirm => 'onlinestore'
}
)
assert_redirected_to '/admin/projects'
end
assert_nil Project.find_by_id(2)
end
def test_destroy_with_normal_user_should_destroy
set_tmp_attachments_directory
@request.session[:user_id] = 2 # non-admin
......
assert_nil Project.find_by_id(2)
end
def test_destroy_with_normal_user_should_destroy_closed_project
set_tmp_attachments_directory
@request.session[:user_id] = 2 # non-admin
Project.find_by_id(2).update_attribute :status, Project::STATUS_CLOSED
assert_difference 'Project.count', -1 do
delete(
:destroy,
:params => {
:id => 2,
:confirm => 'onlinestore'
}
)
assert_redirected_to '/projects'
end
assert_nil Project.find_by_id(2)
end
def test_destroy_with_normal_user_should_not_destroy_with_subprojects
set_tmp_attachments_directory
@request.session[:user_id] = 2 # non-admin
    (1-1/1)