Project

General

Profile

Defect #25867 » 25867.patch

Go MAEDA, 2022-12-08 09:50

View differences:

app/models/issue.rb
def reload(*args)
@workflow_rule_by_attribute = nil
@assignable_versions = nil
@assignable_users = nil
@relations = nil
@spent_hours = nil
@total_spent_hours = nil
......
def assignable_users
return [] if project.nil?
users = project.assignable_users(tracker).to_a
users << author if author && author.active?
if assigned_to_id_was.present? && assignee = Principal.find_by_id(assigned_to_id_was)
users << assignee
end
users.uniq.sort
user_ids = []
user_ids << author_id if author&.active?
user_ids << assigned_to_id_was if assigned_to_id_was.present?
project_users = project.assignable_users(tracker)
user_ids.concat project_users.reorder(nil).ids
@assignable_users = user_ids.empty? ? [] : Principal.where(:id => user_ids).sorted.to_a
end
# Versions that the issue can be assigned to
test/unit/issue_test.rb
assert_kind_of User, Issue.find(1).assignable_users.first
end
test "#assignable_users should be sorted" do
%w(a č u ř c í ý š З д ч и).each do |firstname|
Member.create!(:project_id => 1, :principal => User.generate!(:firstname => firstname), :role_ids => [1])
end
issue = Issue.new(:project => Project.find(1))
assignable_users = Issue.find(1).assignable_users
assert_equal User.where(:id => assignable_users).sorted.pluck(:firstname), assignable_users.map(&:firstname)
end
test "#assignable_users should include the issue author" do
non_project_member = User.generate!
issue = Issue.generate!(:author => non_project_member)
(3-3/3)