Project

General

Profile

Feature #40569 » feature-40569.patch

Mizuki ISHIKAWA, 2024-04-17 09:18

View differences:

app/models/journal.rb
(Setting.notified_events.include?('issue_status_updated') && new_status.present?) ||
(Setting.notified_events.include?('issue_assigned_to_updated') && detail_for_attribute('assigned_to_id').present?) ||
(Setting.notified_events.include?('issue_priority_updated') && new_value_for('priority_id').present?) ||
(Setting.notified_events.include?('issue_fixed_version_updated') && detail_for_attribute('fixed_version_id').present?)
(Setting.notified_events.include?('issue_fixed_version_updated') && detail_for_attribute('fixed_version_id').present?) ||
(Setting.notified_events.include?('issue_attachment_added') && details.any? {|d| d.property == 'attachment' && d.value })
)
Mailer.deliver_issue_edit(self)
end
config/locales/en.yml
label_issue_assigned_to_updated: Assignee updated
label_issue_priority_updated: Priority updated
label_issue_fixed_version_updated: Target version updated
label_issue_attachment_added: Attachment added
label_document: Document
label_document_new: New document
label_document_plural: Documents
lib/redmine/notifiable.rb
notifications << Notifiable.new('issue_assigned_to_updated', 'issue_updated')
notifications << Notifiable.new('issue_priority_updated', 'issue_updated')
notifications << Notifiable.new('issue_fixed_version_updated', 'issue_updated')
notifications << Notifiable.new('issue_attachment_added', 'issue_updated')
notifications << Notifiable.new('news_added')
notifications << Notifiable.new('news_comment_added')
notifications << Notifiable.new('document_added')
test/unit/journal_observer_test.rb
fixtures :issues, :issue_statuses, :journals, :journal_details, :projects,
:projects_trackers, :trackers, :enabled_modules, :enumerations,
:users, :user_preferences, :email_addresses, :roles, :members, :member_roles,
:versions, :issue_categories
:versions, :issue_categories, :attachments
def setup
User.current = nil
......
assert_equal 0, ActionMailer::Base.deliveries.size
end
end
def test_create_should_send_email_notification_with_issue_attachment_added
set_tmp_attachments_directory
with_settings :notified_events => %w(issue_attachment_added) do
user = User.find_by_login('jsmith')
issue = issues(:issues_001)
issue.init_journal(user)
issue.save_attachments(
{ 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')} }
)
assert issue.save
assert_equal 2, ActionMailer::Base.deliveries.size
end
end
def test_create_should_not_send_email_notification_without_issue_attachment_added
set_tmp_attachments_directory
with_settings :notified_events => [] do
user = User.find_by_login('jsmith')
issue = issues(:issues_001)
issue.init_journal(user)
issue.save_attachments(
{ 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')} }
)
assert issue.save
assert_equal 0, ActionMailer::Base.deliveries.size
end
end
end
test/unit/lib/redmine/notifiable_test.rb
def test_all
%w(issue_added issue_updated issue_note_added issue_status_updated
issue_assigned_to_updated issue_priority_updated news_added
issue_assigned_to_updated issue_priority_updated issue_fixed_version_updated issue_attachment_added news_added
news_comment_added document_added file_added
message_posted
wiki_content_added wiki_content_updated).each do |notifiable|
(2-2/2)