Project

General

Profile

Defect #43192 » 0001-Offer-done-values-in-issue-context-menu-based-on-Don.patch

Holger Just, 2025-09-08 21:23

View differences:

app/views/context_menus/issues.html.erb
111 111
    <a href="#" class="submenu"><%= l(:field_done_ratio) %></a>
112 112
    <span class="icon-only"><%= sprite_icon('angle-right', rtl: true) %></span>
113 113
    <ul>
114
    <% (0..10).map{|x|x*10}.each do |p| -%>
114
    <% (0..100).step(Setting.issue_done_ratio_interval.to_i).each do |p| -%>
115 115
        <li><%= context_menu_link "#{p}%", _bulk_update_issues_path(@issue, :ids => @issue_ids, :issue => {'done_ratio' => p}, :back_url => @back), :method => :patch,
116 116
                                      :selected => (@issue && p == @issue.done_ratio), :disabled => (!@can[:edit] || @issues.any?(&:done_ratio_derived?)) %></li>
117 117
    <% end -%>
test/functional/context_menus_controller_test.rb
327 327
    assert_select 'a', :text => 'eCookbook - Shared'
328 328
  end
329 329

  
330
  def test_context_menu_should_respect_five_percent_increments
331
    with_settings :issue_done_ratio => 'issue_field', :issue_done_ratio_interval => 5 do
332
      @request.session[:user_id] = 2
333
      get(
334
        :issues,
335
        :params => {
336
          :ids => [1, 2]
337
        }
338
      )
339
      assert_response :success
340

  
341
      assert_select 'a[href*=?]', '/issues/bulk_update?ids%5B%5D=1&ids%5B%5D=2&issue%5Bdone_ratio%5D=0', :text => '0%'
342
      assert_select 'a[href*=?]', '/issues/bulk_update?ids%5B%5D=1&ids%5B%5D=2&issue%5Bdone_ratio%5D=5', :text => '5%'
343
      assert_select 'a[href*=?]', '/issues/bulk_update?ids%5B%5D=1&ids%5B%5D=2&issue%5Bdone_ratio%5D=10', :text => '10%'
344
      assert_select 'a[href*=?]', '/issues/bulk_update?ids%5B%5D=1&ids%5B%5D=2&issue%5Bdone_ratio%5D=55', :text => '55%'
345
      assert_select 'a[href*=?]', '/issues/bulk_update?ids%5B%5D=1&ids%5B%5D=2&issue%5Bdone_ratio%5D=100', :text => '100%'
346
    end
347
  end
348

  
330 349
  def test_context_menu_should_include_add_subtask_link
331 350
    @request.session[:user_id] = 2
332 351
    get(
(3-3/3)