Project

General

Profile

Download (1.54 KB)

Defect #43521 » 0001-Fix-RegexpError-when-validating-CustomField-with-inv.patch

Marius BĂLTEANU, 2026-01-01 18:13

View differences:

app/models/custom_field.rb
158 158 
      end
159 159 
    end
160 160 

  		




  161
  
  
    
    if default_value.present?

  		




  
  161
  
    
    if default_value.present? && errors[:regexp].blank?

  		




  162
  162
  
    
      validate_field_value(default_value).each do |message|

  		




  163
  163
  
    
        errors.add :default_value, message

  		




  164
  164
  
    
      end

  		












  

    
      test/unit/custom_field_test.rb
    
  





  48
  48
  
    
    assert field.save

  		




  49
  49
  
    
  end

  		




  50
  50
  
    

  		




  
  51
  
    
  def test_regexp_validation_with_invalid_regex_and_default_value

  		




  
  52
  
    
    field = IssueCustomField.new(:name => 'regexp', :field_format => 'text', :regexp => '[', :default_value => 'abc')

  		




  
  53
  
    
    assert !field.save

  		




  
  54
  
    
    assert_include I18n.t('activerecord.errors.messages.invalid'),

  		




  
  55
  
    
                   field.errors[:regexp]

  		




  
  56
  
    
    field.regexp = '[a-z0-9]'

  		




  
  57
  
    
    assert field.save

  		




  
  58
  
    
  end

  		




  
  59
  
    

  		




  51
  60
  
    
  def test_default_value_should_be_validated

  		




  52
  61
  
    
    field = CustomField.new(:name => 'Test', :field_format => 'int')

  		




  53
  62
  
    
    field.default_value = 'abc'

  		















  (2-2/2)