Project

General

Profile

Feature #15167 » 0001-Hide-unused-Options-section-in-spent-time-report.patch

Go MAEDA, 2026-02-15 03:23

View differences:

app/assets/stylesheets/application.css
633 633
.query-totals>span:not(:first-child) {margin-inline-start: 0.6em;}
634 634
.query-totals .value {font-weight:bold;}
635 635
body.controller-timelog .query-totals {margin-block-start: initial;}
636
/* Spent time report does not use options, hide the options section */
637
body.controller-timelog.action-report fieldset#options {display: none;}
636 638

  
637 639
body.controller-gantts fieldset#options > div > div {
638 640
  display: flex;
app/views/timelog/report.html.erb
13 13
  <% @report.criteria.each do |criterion| %>
14 14
    <%= hidden_field_tag 'criteria[]', criterion, :id => nil %>
15 15
  <% end %>
16
  <%# Report view does not use query options for results, so the options section is hidden by CSS. %>
16 17
  <%= render :partial => 'timelog/date_range' %>
17 18

  
18 19
  <p><label for='columns'><%= l(:label_details) %></label>: <%= select_tag 'columns', options_for_select([[l(:label_year), 'year'],
test/system/timelog_test.rb
100 100
      assert page.has_no_text?('Comment')
101 101
    end
102 102
  end
103

  
104
  def test_report_should_hide_options
105
    log_user 'jsmith', 'jsmith'
106
    visit '/projects/ecookbook/time_entries/report'
107

  
108
    assert_selector 'fieldset#options', visible: :hidden
109
  end
103 110
end
(2-2/2)