Project

General

Profile

Defect #43838 » 0002-Add-an-index-to-users-login-to-speed-up-find-user-by.patch

Marius BĂLTEANU, 2026-02-28 07:28

View differences:

app/models/user.rb
def self.find_by_login(login)
login = Redmine::CodesetUtil.replace_invalid_utf8(login.to_s)
if login.present?
users = where(:login => login)
# First look for an exact match
user = where(:login => login).detect {|u| u.login == login}
user = users.detect {|u| u.login == login}
unless user
# Fail over to case-insensitive if none was found
user = find_by("LOWER(login) = ?", login.downcase)
if Redmine::Database.mysql? || Redmine::Database.sqlserver?
# MySQL and SQLServer are case-insensitive by default, we can search in the existing results
user = users.detect {|u| u.login.casecmp?(login)}
else
user = find_by("LOWER(login) = ?", login.downcase)
end
end
user
end
db/migrate/20260225170822_add_index_to_users_login.rb
class AddIndexToUsersLogin < ActiveRecord::Migration[8.1]
def up
add_index :users, :login
end
def down
remove_index :users, :login
end
end
lib/redmine/database.rb
mysql? ? ActiveRecord::Base.connection.select_value("SELECT VERSION()") : nil
end
def sqlserver?
/sqlserver/i.match?(ActiveRecord::Base.connection.adapter_name)
end
# Returns a SQL statement for case/accent (if possible) insensitive match
def like(left, right, options={})
neg = (options[:match] == false ? 'NOT ' : '')
(6-6/6)