Redmine

  helper_method :per_page_option

    redirect_to settings_project_path(@project, members_settings_query)

  end

  # Keeps the members tab and its pagination when redirecting after add/edit/remove

  def members_settings_query

    query = {:tab => 'members'}

    query[:members_page] = params[:members_page] if params[:members_page].present?

    query[:per_page] = params[:per_page] if params[:per_page].present?

    query

  # Returns the requested page of the project's members together with its

  # paginator and the total member count. Member.sorted joins roles (a member

  # may have several roles), so the sorted ids are collected first (duplicates

  # removed, keeping the lowest role position) and only the current page is

  # loaded; this paginates members rather than join rows.

  def paginate_members(project)

    ordered_ids =

      project.memberships.

        left_joins(:member_roles => :role).joins(:principal).

        reorder("#{Role.table_name}.position").

        order(Principal.fields_for_order_statement).

        pluck("#{Member.table_name}.id").uniq

    member_pages = Redmine::Pagination::Paginator.new(ordered_ids.size, per_page_option, params['members_page'], 'members_page')

    page_ids = ordered_ids[member_pages.offset, member_pages.per_page] || []

    members_by_id = project.memberships.where(:id => page_ids).preload(:project, :principal, :roles).index_by(&:id)

    members = page_ids.filter_map {|id| members_by_id[id]}

    [members, member_pages, ordered_ids.size]

  end

<%= form_for(@member, :url => membership_path(@member, :members_page => params[:members_page]),

<%= form_for @member, :as => :membership, :url => project_memberships_path(@project, :members_page => params[:members_page]), :remote => true, :method => :post do |f| %>

<%

  # A dedicated 'members_page' parameter is used so it does not clash with the

  # 'page' used by the new-member modal's principal list (render_principals_for_new_members).

  members, member_pages, member_count = paginate_members(@project)

%>

<p><%= link_to sprite_icon('add', l(:label_member_new)), new_project_membership_path(@project, :members_page => params[:members_page]), :remote => true, :class => "icon icon-add" %></p>

                  edit_membership_path(member, :members_page => params[:members_page]),

      <%= remove_link membership_path(member, :members_page => params[:members_page]),

<span class="pagination">

  <%= pagination_links_full(member_pages, member_count) do |text, parameters, options|

        link_to text, settings_project_path(@project, 'members', request.query_parameters.merge(parameters)), options

      end %>

</span>

  def test_update_xhr_should_keep_members_tab_in_pagination_links

    project = Project.find(1)

    26.times { User.add_to_project(User.generate!, project) }

    @request.session[:user_id] = 2

    with_settings :per_page_options => '25,50,100' do

      put(

        :update,

        :params => {

          :id => 2,

          :membership => {:role_ids => [1]}

        },

        :xhr => true

      )

    end

    assert_response :success

    # The re-rendered members tab keeps its pagination links scoped to the members tab

    assert_match %r{settings/members\?members_page=}, response.body

  end

  def test_edit_xhr_should_keep_current_page_in_form_action

    @request.session[:user_id] = 2

    get(:edit, :params => {:id => 2, :members_page => 2}, :xhr => true)

    assert_response :success

    # The edit form posts back with the current page so the list stays on it after saving

    assert_match %r{/memberships/2\?members_page=2}, response.body

  end

  def test_new_xhr_should_keep_current_page_in_form_action

    @request.session[:user_id] = 2

    get(:new, :params => {:project_id => 1, :members_page => 2}, :xhr => true)

    assert_response :success

    # The new member form posts with the members-tab page so the list stays on it after adding

    assert_match %r{/projects/ecookbook/memberships\?members_page=2}, response.body

  end

  def test_settings_members_should_be_paginated

    project = Project.find(1)

    per_page = 25

    # Ensure there are more members than fit on a single page

    (per_page + 5).times { User.add_to_project(User.generate!, project) }

    @request.session[:user_id] = 2

    with_settings :per_page_options => '25,50,100' do

      get(

        :settings,

        :params => {:id => 'ecookbook', :tab => 'members'}

      )

    end

    assert_response :success

    assert_select 'div#tab-content-members table.list.members tbody tr.member', :count => per_page

    assert_select 'div#tab-content-members span.pagination'

    # Pagination links must keep the members tab in the path and use members_page

    assert_select 'div#tab-content-members span.pagination a[href*=?]', 'settings/members?members_page='

  end

  def test_settings_members_with_multiple_roles_should_not_appear_on_two_pages

    project = Project.find(1)

    30.times { User.add_to_project(User.generate!, project) }

    # A member with several roles must still be listed once (no join-row paging)

    Member.where(:project_id => project.id).first.update!(:role_ids => [1, 2])

    @request.session[:user_id] = 2

    page1 = page2 = nil

    with_settings :per_page_options => '25,50,100' do

      get(:settings, :params => {:id => 'ecookbook', :tab => 'members'})

      page1 = css_select('div#tab-content-members tr.member').pluck('id')

      get(:settings, :params => {:id => 'ecookbook', :tab => 'members', :members_page => 2})

      page2 = css_select('div#tab-content-members tr.member').pluck('id')

    end

    assert_not page1.intersect?(page2), 'a member must not appear on more than one page'

  end

  def test_settings_members_should_show_requested_page

    project = Project.find(1)

    per_page = 25

    (per_page + 5).times { User.add_to_project(User.generate!, project) }

    @request.session[:user_id] = 2

    with_settings :per_page_options => '25,50,100' do

      get(

        :settings,

        :params => {:id => 'ecookbook', :tab => 'members', :members_page => 2}

      )

    end

    assert_response :success

    # The second page holds the remaining members (fewer than a full page)

    assert_select 'div#tab-content-members table.list.members tbody tr.member'

    assert_select 'div#tab-content-members span.pagination'

  end

  def test_paginate_members_returns_only_the_requested_page

    # per_page_option is provided by ApplicationController in the running app

    stubs(:per_page_option).returns(3)

    project = Project.generate!

    5.times { User.add_to_project(User.generate!, project) }

    members, member_pages, member_count = paginate_members(project)

    assert_equal 3, members.size

    assert_equal 3, member_pages.per_page

    assert_equal project.memberships.count, member_count

  end

  def test_paginate_members_lists_a_member_with_several_roles_once

    stubs(:per_page_option).returns(3)

    project = Project.generate!

    3.times { User.add_to_project(User.generate!, project) }

    # Give one member several roles: Member.sorted would return it on multiple

    # join rows, but it must still be listed only once.

    Member.where(:project_id => project.id).first.update!(:role_ids => [1, 2])

    members, _member_pages, member_count = paginate_members(project)

    member_ids = members.map(&:id)

    assert_equal member_ids.uniq, member_ids

    assert_equal member_count, members.size

    assert_equal project.memberships.count, member_count

  end