Feature #44374 » 0001-Cache-builtin-group-instances-per-request-to-avoid-r.patch
| app/models/group_builtin.rb | ||
|---|---|---|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
||
|
class GroupBuiltin < Group
|
||
|
class Current < ActiveSupport::CurrentAttributes
|
||
|
attribute :instances
|
||
|
end
|
||
|
validate :validate_uniqueness, :on => :create
|
||
|
def validate_uniqueness
|
||
| ... | ... | |
|
def load_instance
|
||
|
return nil if self == GroupBuiltin
|
||
|
instance = unscoped.order(:id).first || create_instance
|
||
|
Current.instances ||= {}
|
||
|
Current.instances[self] ||= unscoped.order(:id).first || create_instance
|
||
|
end
|
||
|
def create_instance
|
||
| test/unit/group_test.rb | ||
|---|---|---|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
||
|
require_relative '../test_helper'
|
||
|
require 'active_record/testing/query_assertions'
|
||
|
class GroupTest < ActiveSupport::TestCase
|
||
|
include Redmine::I18n
|
||
|
include ActiveRecord::Assertions::QueryAssertions
|
||
|
def setup
|
||
|
User.current = nil
|
||
| ... | ... | |
|
end
|
||
|
end
|
||
|
def test_builtin_groups_should_be_cached_until_current_attributes_reset
|
||
|
assert_queries_count(1) { Group.anonymous }
|
||
|
assert_no_queries { Group.anonymous }
|
||
|
GroupBuiltin::Current.reset
|
||
|
assert_queries_count(1) { Group.anonymous }
|
||
|
end
|
||
|
def test_builtin_in_group_should_be_uniq
|
||
|
group = GroupAnonymous.new
|
||
|
group.name = 'Foo'
|
||