Project

General

Profile

Patch #44392 ยป use-file-read.patch

Go MAEDA, 2026-08-28 08:21

View differences:

.rubocop_todo.yml
- 'app/models/user.rb'
- 'config/initializers/00-core_plugins.rb'
# This cop supports unsafe autocorrection (--autocorrect-all).
Security/IoMethods:
Exclude:
- 'app/models/attachment.rb'
- 'test/functional/mail_handler_controller_test.rb'
- 'test/unit/mail_handler_test.rb'
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle.
# SupportedStyles: separated, grouped
app/models/attachment.rb
filename = "#{basename}(#{dup_count})#{extname}"
end
zos.put_next_entry(filename)
zos << IO.binread(attachment.diskfile)
zos << File.binread(attachment.diskfile)
archived_file_names << filename
end
end
test/functional/mail_handler_controller_test.rb
:params => {
:key => 'secret',
:email =>
IO.read(
File.read(
File.join(FIXTURES_PATH, 'ticket_on_given_project.eml')
)
}
......
:params => {
:key => 'secret',
:email =>
IO.read(
File.read(
File.join(FIXTURES_PATH, 'ticket_on_given_project.eml')
),
:issue => {
......
:index,
:params => {
:key => 'secret',
:email => IO.read(File.join(FIXTURES_PATH, 'ticket_reply.eml'))
:email => File.read(File.join(FIXTURES_PATH, 'ticket_reply.eml'))
}
)
end
......
:params => {
:key => 'secret',
:email =>
IO.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
File.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
}
)
end
......
:params => {
:key => 'secret',
:email =>
IO.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
File.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
}
)
end
......
:params => {
:key => 'wrong',
:email =>
IO.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
File.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
}
)
end
test/unit/mail_handler_test.rb
"Auto-Submitted: auto-generated",
'X-Autoreply: yes'
].each do |header|
raw = IO.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
raw = File.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
raw = header + "\n" + raw
assert_no_difference 'Issue.count' do
......
[
"Auto-Submitted: auto-forwarded"
].each do |header|
raw = IO.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
raw = File.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
raw = header + "\n" + raw
assert_difference 'Issue.count', 1 do
......
private
def submit_email(filename, options={})
raw = IO.read(File.join(FIXTURES_PATH, filename))
raw = File.read(File.join(FIXTURES_PATH, filename))
yield raw if block_given?
MailHandler.receive(raw, options)
end
    (1-1/1)