Patch #44392 ยป use-file-read.patch
| .rubocop_todo.yml | ||
|---|---|---|
| 579 | 579 |
- 'app/models/user.rb' |
| 580 | 580 |
- 'config/initializers/00-core_plugins.rb' |
| 581 | 581 | |
| 582 |
# This cop supports unsafe autocorrection (--autocorrect-all). |
|
| 583 |
Security/IoMethods: |
|
| 584 |
Exclude: |
|
| 585 |
- 'app/models/attachment.rb' |
|
| 586 |
- 'test/functional/mail_handler_controller_test.rb' |
|
| 587 |
- 'test/unit/mail_handler_test.rb' |
|
| 588 | ||
| 589 | 582 |
# This cop supports safe autocorrection (--autocorrect). |
| 590 | 583 |
# Configuration parameters: EnforcedStyle. |
| 591 | 584 |
# SupportedStyles: separated, grouped |
| app/models/attachment.rb | ||
|---|---|---|
| 454 | 454 |
filename = "#{basename}(#{dup_count})#{extname}"
|
| 455 | 455 |
end |
| 456 | 456 |
zos.put_next_entry(filename) |
| 457 |
zos << IO.binread(attachment.diskfile)
|
|
| 457 |
zos << File.binread(attachment.diskfile)
|
|
| 458 | 458 |
archived_file_names << filename |
| 459 | 459 |
end |
| 460 | 460 |
end |
| test/functional/mail_handler_controller_test.rb | ||
|---|---|---|
| 38 | 38 |
:params => {
|
| 39 | 39 |
:key => 'secret', |
| 40 | 40 |
:email => |
| 41 |
IO.read(
|
|
| 41 |
File.read(
|
|
| 42 | 42 |
File.join(FIXTURES_PATH, 'ticket_on_given_project.eml') |
| 43 | 43 |
) |
| 44 | 44 |
} |
| ... | ... | |
| 60 | 60 |
:params => {
|
| 61 | 61 |
:key => 'secret', |
| 62 | 62 |
:email => |
| 63 |
IO.read(
|
|
| 63 |
File.read(
|
|
| 64 | 64 |
File.join(FIXTURES_PATH, 'ticket_on_given_project.eml') |
| 65 | 65 |
), |
| 66 | 66 |
:issue => {
|
| ... | ... | |
| 87 | 87 |
:index, |
| 88 | 88 |
:params => {
|
| 89 | 89 |
:key => 'secret', |
| 90 |
:email => IO.read(File.join(FIXTURES_PATH, 'ticket_reply.eml'))
|
|
| 90 |
:email => File.read(File.join(FIXTURES_PATH, 'ticket_reply.eml'))
|
|
| 91 | 91 |
} |
| 92 | 92 |
) |
| 93 | 93 |
end |
| ... | ... | |
| 108 | 108 |
:params => {
|
| 109 | 109 |
:key => 'secret', |
| 110 | 110 |
:email => |
| 111 |
IO.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
|
|
| 111 |
File.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
|
|
| 112 | 112 |
} |
| 113 | 113 |
) |
| 114 | 114 |
end |
| ... | ... | |
| 128 | 128 |
:params => {
|
| 129 | 129 |
:key => 'secret', |
| 130 | 130 |
:email => |
| 131 |
IO.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
|
|
| 131 |
File.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
|
|
| 132 | 132 |
} |
| 133 | 133 |
) |
| 134 | 134 |
end |
| ... | ... | |
| 148 | 148 |
:params => {
|
| 149 | 149 |
:key => 'wrong', |
| 150 | 150 |
:email => |
| 151 |
IO.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
|
|
| 151 |
File.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
|
|
| 152 | 152 |
} |
| 153 | 153 |
) |
| 154 | 154 |
end |
| test/unit/mail_handler_test.rb | ||
|---|---|---|
| 907 | 907 |
"Auto-Submitted: auto-generated", |
| 908 | 908 |
'X-Autoreply: yes' |
| 909 | 909 |
].each do |header| |
| 910 |
raw = IO.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
|
|
| 910 |
raw = File.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
|
|
| 911 | 911 |
raw = header + "\n" + raw |
| 912 | 912 | |
| 913 | 913 |
assert_no_difference 'Issue.count' do |
| ... | ... | |
| 920 | 920 |
[ |
| 921 | 921 |
"Auto-Submitted: auto-forwarded" |
| 922 | 922 |
].each do |header| |
| 923 |
raw = IO.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
|
|
| 923 |
raw = File.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
|
|
| 924 | 924 |
raw = header + "\n" + raw |
| 925 | 925 | |
| 926 | 926 |
assert_difference 'Issue.count', 1 do |
| ... | ... | |
| 1493 | 1493 |
private |
| 1494 | 1494 | |
| 1495 | 1495 |
def submit_email(filename, options={})
|
| 1496 |
raw = IO.read(File.join(FIXTURES_PATH, filename))
|
|
| 1496 |
raw = File.read(File.join(FIXTURES_PATH, filename))
|
|
| 1497 | 1497 |
yield raw if block_given? |
| 1498 | 1498 |
MailHandler.receive(raw, options) |
| 1499 | 1499 |
end |