Project

General

Profile

Forums » Open discussion »

Show date range filter in one line and move tabs to a dedicated partial

Added by Daniel Neis Araujo over 13 years ago

Hello,

i've submitted a short patch that changes the date range filter of time log in one visible way, that is to show filters options in one line instead of three; and in one "invisible" way, that is to move "Details" and "Report" tabs from "date_range" partial to a dedicated "tabs" partial.

http://www.redmine.org/issues/7190

This is my first contribution to the project.
Hope you like.

Daniel


Replies (3)

RE: Show date range filter in one line and move tabs to a dedicated partial - Added by Mischa The Evil over 13 years ago

Daniel Neis Araujo wrote:

[...] that changes the date range filter of time log in one visible way, that is to show filters options in one line instead of three;

I personally don't like it all squeezed into one single line. I prefer the current layout.

[...] and in one "invisible" way, that is to move "Details" and "Report" tabs from "date_range" partial to a dedicated "tabs" partial.

Nice, that's a better place for those tabs then where they are currently indeed.

RE: Show date range filter in one line and move tabs to a dedicated partial - Added by Felix Schäfer over 13 years ago

Daniel Neis Araujo wrote:

This is my first contribution to the project.

Thanks for contributing, please refrain from posting the same things multiple times though: either make a new ticket if you want to share code or open a new forum thread if you want to discuss things, but don't do both, thanks.

RE: Show date range filter in one line and move tabs to a dedicated partial - Added by Daniel Neis Araujo over 13 years ago

Felix Schäfer wrote:

Daniel Neis Araujo wrote:

This is my first contribution to the project.

Thanks for contributing, please refrain from posting the same things multiple times though: either make a new ticket if you want to share code or open a new forum thread if you want to discuss things, but don't do both, thanks.

Oh, sorry, i am used to contribute to Moodle project, where there is so many open issues that we have to tell people in foruns to discuss issues...

    (1-3/3)