Redmine

Our Redmine installation allows LDAP logins through Active Directory. However, the user accounts set up there have names containing spaces (they're users' full names), which aren't allowed in Redmine.

I'm not at liberty to alter AD accounts, and adding an LDAP attribute containing a Redmine-compatible username isn't an option. Therefore, I made a minor adjustment to app/models/user.rb: line 59 becomes

validates_format_of :login, :with => /^[A-Za-z][A-Za-z0-9 ]*[a-z0-9]$/

thus, logins start with a letter, end with a lowercase letter or number, and between those two are letters, numbers or spaces. This is sufficient for our particular configuration.

Everything seems to work fine, both with on-the-fly user creation and from scripts/console, but I was wondering if there were any implications I hadn't considered.

Additionally, hacking at Redmine's source code isn't preferred, of course. In fact, I'd already forgotten to reinstate this patch when I upgraded our installation earlier today. Is there any hope of making the regexp configurable?

Thanks.