Project

General

Profile

Actions

Defect #11209

closed

Wiki diff may generate broken HTML

Added by Kouhei Sutou almost 11 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Category:
Wiki
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

If Wiki diff has a new line (not a changed line), diff page may generates broken HTML like:

<div class="text-diff">
h1. CookBook documentation 
<br /> Some updated [[documentation]] here... <span class="diff_in">
<br /> More contents...&lt;/span&gt;
</div>

Close </span> tag is escaped.

For example:

Before

h1. CookBook documentation
Some updated [[documentation]] here...

After:

h1. CookBook documentation
Some updated [[documentation]] here...
More contents...

"More contents..." line is added. This case, diff page generates broken HTML.


Files


Related issues

Has duplicate Redmine - Defect #11735: Weird diffs in wiki pages.Closed

Actions
Actions #1

Updated by Kouhei Sutou almost 11 years ago

I attach a patch and test case for this issue.
It adds a new fixture data. So it may break other tests. I only tested this patch against test/functional/wiki_controller_test.rb. Sorry.

Actions #2

Updated by Jean-Philippe Lang almost 11 years ago

  • Status changed from New to Confirmed
Actions #3

Updated by Jean-Philippe Lang almost 11 years ago

  • Subject changed from diff page for Wiki may generate broken HTML to Wiki diff may generate broken HTML
  • Status changed from Confirmed to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version set to 2.0.4
  • Resolution set to Fixed

Fixed in r9895 with slight changes, thanks for digging into this.

Actions #4

Updated by Kouhei Sutou almost 11 years ago

Thanks!

I've also found a similar problem in Wiki update notification mail. I'll submit a new ticket with test case later.

Actions #5

Updated by Jean-Philippe Lang over 10 years ago

  • Status changed from Resolved to Closed

Merged.

Actions

Also available in: Atom PDF