Wiki diff may generate broken HTML
|Assignee:||Jean-Philippe Lang||% Done:|
If Wiki diff has a new line (not a changed line), diff page may generates broken HTML like:
<div class="text-diff"> h1. CookBook documentation <br /> Some updated [[documentation]] here... <span class="diff_in"> <br /> More contents...</span> </div>
</span> tag is escaped.
h1. CookBook documentation Some updated [[documentation]] here...
h1. CookBook documentation Some updated [[documentation]] here... More contents...
"More contents..." line is added. This case, diff page generates broken HTML.
#1 Updated by Kouhei Sutou over 8 years ago
I attach a patch and test case for this issue.
It adds a new fixture data. So it may break other tests. I only tested this patch against test/functional/wiki_controller_test.rb. Sorry.
#3 Updated by Jean-Philippe Lang over 8 years ago
- Subject changed from diff page for Wiki may generate broken HTML to Wiki diff may generate broken HTML
- Status changed from Confirmed to Resolved
- Assignee set to Jean-Philippe Lang
- Target version set to 2.0.4
- Resolution set to Fixed
Fixed in r9895 with slight changes, thanks for digging into this.