Patch #13697
closed
Back-button on diff page is not working when I'm directed from email
Added by Filou Centrinov over 12 years ago.
Updated over 12 years ago.
Description
Situation:
I get an email from Redmine with a diff-link to the changed description of an issue. I click on that link in my email to get informed about changed details.
Problem:
When I click now on the back-link on the diff page, nothing happends.
Reason:
The back-link tries to get the page I've been before (history.back()), but there not such a page.
I fixed this problem with a patch.
Files
- Description updated (diff)
Woudn't you agree to apply this patch? Otherwise I can't go from a diff page to its issue page.
- Status changed from New to Closed
- Target version set to 2.4.0
Committed in trunk r11893, thanks.
- Status changed from Closed to Reopened
The problem is, that browsers handle history.length differently: http://www.w3schools.com/jsref/prop_his_length.asp
I would suggest the following code, tested on Firefox, IE and Opera:
history.back(); return (document.referrer=="");
or
if (document.referrer!="") {history.back(); return false;}
I tested it like this: history.back(); alert((document.referrer=="")); return (document.referrer=="");
- Status changed from Reopened to Closed
Committed in trunk r11900, thanks.
Also available in: Atom
PDF
Updated by 
Updated by Toshi MARUYAMA