Project

General

Profile

Actions

Defect #1434

closed

CVS: add support for modules names with spaces

Added by Vladymyr Vladymyrov almost 16 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
SCM
Target version:
Start date:
2008-06-12
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

redmine fails to import changes from CVS module with space in the name:
For example module: "module with spaces" - redmine generate command which makes cvs to treat the module name as several modules separated with spaces.

Solution is to put module name into the quotes:

Here is patch to fix this:
file: lib/redmine/scm/adapters/cvs_adapter.rb

68c68
<           cmd << " #{path_with_project}" 
---
>           cmd << ' "'+"#{path_with_project}"+'"'
113c113
<           cmd << " #{path_with_project}" 
---
>           cmd << ' "'+"#{path_with_project}"+'"'


Related issues

Has duplicate Redmine - Defect #1642: CVS: add support for modules names with spaces (was #1434).Closed2008-07-14

Actions
Actions #1

Updated by Vladymyr Vladymyrov almost 16 years ago

Here is full fix - for all cvs 8 calls the adapter does:

68c68
<           cmd << " #{path_with_project}" 
---
>           cmd << ' "'+"#{path_with_project}"+'"'
113c113
<           cmd << " #{path_with_project}" 
---
>           cmd << ' "'+"#{path_with_project}"+'"'
233c233
<           cmd = "#{CVS_BIN} -d #{root_url} rdiff -u -r#{identifier_to} -r#{identifier_from} #{path_with_project}" 
---
>           cmd = "#{CVS_BIN} -d #{root_url} rdiff -u -r#{identifier_to} -r#{identifier_from} \"#{path_with_project}\"" 
248c248
<           cmd = "#{CVS_BIN} -d #{root_url} co -r#{identifier} -p #{path_with_project}" 
---
>           cmd = "#{CVS_BIN} -d #{root_url} co -r#{identifier} -p \"#{path_with_project}\"" 
261c261
<           cmd = "#{CVS_BIN} -d #{root_url} rannotate -r#{identifier} #{path_with_project}" 
---
>           cmd = "#{CVS_BIN} -d #{root_url} rannotate -r#{identifier} \"#{path_with_project}\"" 
Actions #2

Updated by Jean-Philippe Lang almost 16 years ago

  • Status changed from New to Closed
  • Target version changed from 0.8 to 0.7.2
  • Resolution set to Fixed

Fixed in r1527 using the shell_quote method instead.

Actions #3

Updated by Jean-Philippe Lang over 15 years ago

  • Target version changed from 0.7.2 to 0.8
Actions #4

Updated by John Vanton about 14 years ago

  • Assignee deleted (Jean-Philippe Lang)
Actions

Also available in: Atom PDF