Project

General

Profile

Actions
Copy link

Defect #14422

closed

CVS root_url not recognized when connection string does not include port

Added by Dominik Follmann almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
SCM
Target version:
2.3.3
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

The patch fixes a bug in the CVS SCM module of the standard version of redmine (2.3.1).
Without this bugfix, the revisions are not handled correctly. Each revision-number (e.g. 1.4) is only accepted once by the redmine repository, although each file has its own revision-numbers.

In our case the CVSROOT looks like this:

:pserver:cvs_user:cvs_password@123.456.789.123:9876/repo

The problem is located in \lib\redmine\scm\adapters\cvs_adapter.rb in the method root_url_path
--> RegExp was changed from 
/^:.+:\d*/
to 
/^(:.+)+@\d+(.\d+)+/

This lets the property return the correct part of the CVSROOT-URL
("/repo" instead of "::9876/repo")
And now the function 'fetch_changesets' works as expected with CVS.

Find attached the patch file.

Files

Download all files
cvs_adapter.rb.patch (246 Bytes) cvs_adapter.rb.patch Dominik Follmann, 2013-07-10 08:39
cvs_adapter.rb (1).patch (246 Bytes) cvs_adapter.rb (1).patch tyrel cropper, 2013-07-26 05:01
Actions
Copy link

Also available in: Atom PDF