Patch #15072

Optimization of issues journal custom fields display

Added by Jérôme BATAILLE about 4 years ago. Updated 7 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Code cleanup/refactoring
Target version:2.4.0

Description

Custom filed is reloaded for each detail
even if cached by active record, we can avoid to reload them

RM_15072_optimization_not_reload_custom_field_V2.3.2.diff Magnifier (973 Bytes) Jérôme BATAILLE, 2013-10-09 12:24

Associated revisions

Revision 12217
Added by Jean-Philippe Lang about 4 years ago

Avoid lots of CustomField.find_by_id calls when displaying an issue history with custom fields (#15072).

History

#2 Updated by Jean-Philippe Lang about 4 years ago

  • Category changed from Issues to Code cleanup/refactoring
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version set to 2.4.0

I've committed r12217 which avoids much more of these cache hits, thanks for pointing this out.

#3 Updated by Jérôme BATAILLE about 4 years ago

Sure your solution is more efficient.
Thanks !

#4 Updated by Jérôme BATAILLE 8 months ago

Hi, you can indicate in the Resolution that's it's Fixed, if you have the time to, thanks a lot.

#5 Updated by Toshi MARUYAMA 7 months ago

Jérôme BATAILLE wrote:

Hi, you can indicate in the Resolution that's it's Fixed, if you have the time to, thanks a lot.

"patch" tracker does not have "resolution" filed.

Also available in: Atom PDF