Project

General

Profile

Actions

Defect #15113

closed

The mail method should return a Mail::Message

Added by Florian Schwab over 10 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

The overwritten mail method (ActionMailer::Base) in source:trunk/app/models/mailer.rb should return a Mail object instead of a symbol (the locale set/returned by set_language_if_valid) to be compliant with the original mail method.


Files

mailer_return_value.patch (1021 Bytes) mailer_return_value.patch Florian Schwab, 2013-10-12 14:11
Actions #1

Updated by Jean-Philippe Lang over 10 years ago

  • Subject changed from The mail method should return a object of type Mail to The mail method should return a Mail::Message
  • Category set to Code cleanup/refactoring
  • Status changed from New to Closed
  • Assignee set to Florian Schwab
  • Target version set to 2.4.0
  • Resolution set to Fixed

The patch broke a test. I've fixed it and added a test in r12210, thanks.

Actions

Also available in: Atom PDF