Feature #15311
Add an indication to admin/info whether or not ImageMagick convert is available
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | Administration | |||
| Target version: | 2.4.0 | |||
| Resolution: | Fixed |
Description
ImageMagick convert is now used for generating thumbnails1 which makes it (specifically ImageMagick) an optional dependency.
Inspired by #15297#note-1 and some others I think it would be good if its availability is indicated on admin/info.
1 for both issue attachments thumbnails as well as macro thumbnails
Associated revisions
Add an indication to admin/info whether or not ImageMagick convert is available (#15311).
Patch by Mischa The Evil.
History
#1
Updated by Mischa The Evil over 7 years ago
- File rm15311-add_convert_availability_indication-trunk_r12240.diff
added - File rm15311-add_convert_availability_indication.png added
Patch, including English and Dutch translations (EN stubs for others) attached. A test for this tiny change is omitted.
The essence of the patch:
Index: app/controllers/admin_controller.rb
===================================================================
--- app/controllers/admin_controller.rb (revision 12240)
+++ app/controllers/admin_controller.rb (working copy)
@@ -77,7 +77,8 @@
[:text_default_administrator_account_changed, User.default_admin_account_changed?],
[:text_file_repository_writable, File.writable?(Attachment.storage_path)],
[:text_plugin_assets_writable, File.writable?(Redmine::Plugin.public_directory)],
- [:text_rmagick_available, Object.const_defined?(:Magick)]
+ [:text_rmagick_available, Object.const_defined?(:Magick)],
+ [:text_convert_available, Redmine::Thumbnail.convert_available?]
]
end
end
This changes admin/info like:
#2
Updated by Jean-Philippe Lang over 7 years ago
- Category changed from UI to Administration
- Status changed from New to Closed
- Target version set to 2.4.0
- Resolution set to Fixed
Thanks for patch, it's committed in r12278.