Project

General

Profile

Actions

Patch #15689

closed

Make favicon themeable

Added by Felix Schäfer about 10 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Category:
Themes
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Plan.io had the case that we needed to be able to set the favicon according to the theme. We have developed a patch to be able to use a favicon from the favicon directory in the theme directory (if more than one is available the [].first will be used).

(Patch coming up as soon as I have an issue number)


Files

15689-theme_favicon.patch (1.5 KB) 15689-theme_favicon.patch Felix Schäfer, 2013-12-12 16:10
15689-theme_favicon.patch (3.34 KB) 15689-theme_favicon.patch Felix Schäfer, 2013-12-14 12:31
Actions #1

Updated by Felix Schäfer about 10 years ago

Here's the patch.

Actions #2

Updated by Jan Niggemann (redmine.org team member) about 10 years ago

  • Tracker changed from Feature to Patch
  • Status changed from Resolved to New
Actions #4

Updated by Felix Schäfer about 10 years ago

Sure, see the attached updated patch.

Actions #5

Updated by Jean-Philippe Lang about 10 years ago

  • Target version set to 2.5.0
Actions #6

Updated by Jean-Philippe Lang about 10 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
Patch committed in r12646 with slight changes:
  • ruby 1.8 compatibility syntax
  • use of #assert_select instead of #assert_tag

Thanks.

Actions #7

Updated by Felix Schäfer about 10 years ago

Thanks!

Actions

Also available in: Atom PDF