Project

General

Profile

Actions

Defect #16808

closed

No hook for issues closed by commit

Added by Sidney San Martín about 11 years ago. Updated about 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Issues
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Invalid
Affected version:

Description

Notification plugins like zulip-redmine-plugin seem to use the controller_issues_edit_after_save hook. It doesn't look like this hook gets triggered when I mention or close an issue in a commit (e.g. "fixes #whatever" in a commit message), so we don't get notified.

Should this hook be getting triggered in this case, or is there a general "issue changed" hook we could use?

Actions #1

Updated by Jean-Philippe Lang about 11 years ago

  • Status changed from New to Closed
  • Resolution set to Invalid

Controller hooks are used to handle custom params (eg. retrieving from form elements added by a plugin).
If you need a hook at model level that is triggered when an object is updated, you should use regular ActiveRecord callbacks instead.

Actions

Also available in: Atom PDF