Project

General

Profile

Actions
Copy link

Patch #16905

closed

Count users with a single query on group list

Added by Jérôme BATAILLE about 9 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Code cleanup/refactoring
Target version:
2.6.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

All users are loaded for each group, only to count them !

Files

RM_16905_groups_index_users_count_optim.diff (981 Bytes) RM_16905_groups_index_users_count_optim.diff Jérôme BATAILLE, 2014-05-16 16:17
Actions
Copy link
 #2

Updated by Jean-Philippe Lang about 9 years ago

  • Subject changed from Admin : groups otpimization of users count to Count users with a single query on group list
  • Category changed from Groups to Code cleanup/refactoring
  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version set to 2.6.0

This patch didn't work for me, as the hash keys are strings (tested with postgresql):

irb(main):001:0> User.joins(:groups).group('group_id').count
=> {"98913"=>2}

Fix committed in r13149 with test.

Actions
Copy link
 #3

Updated by Jérôme BATAILLE about 9 years ago

Jean-Philippe, thanks to have reviewed this patch.

Actions
Copy link
 #4

Updated by Jean-Philippe Lang over 8 years ago

  • Status changed from Resolved to Closed
Actions
Copy link
 #5

Updated by Jérôme BATAILLE about 6 years ago

Hi, you can indicate in the Resolution that's it's Fixed, if you have the time to, thanks a lot.

Actions
Copy link
 #6

Updated by Toshi MARUYAMA about 6 years ago

Jérôme BATAILLE wrote:

Hi, you can indicate in the Resolution that's it's Fixed, if you have the time to, thanks a lot.

"patch" tracker does not have "resolution" filed.

Actions
Copy link

Also available in: Atom PDF