Defect #17581

Drag & Drop does not work with Safari 5.1

Added by fred bregar over 3 years ago. Updated about 3 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Attachments
Target version:2.4.7
Resolution:Fixed Affected version:2.5.2

Description

see #13932-13 - i would have re-opened but i do not have permission


Related issues

Related to Redmine - Defect #13932: File upload does not work with Safari Closed

Associated revisions

Revision 13346
Added by Toshi MARUYAMA about 3 years ago

fix Drag & Drop does not work with Safari 5.1 (#17581, #13932)

Contributed by fred bregar.

Revision 13348
Added by Toshi MARUYAMA about 3 years ago

Merged r13346 from trunk to 2.5-stable (#17581, #13932)

fix Drag & Drop does not work with Safari 5.1.

Contributed by fred bregar.

Revision 13349
Added by Toshi MARUYAMA about 3 years ago

Merged r13346 from trunk to 2.4-stable (#17581, #13932)

fix Drag & Drop does not work with Safari 5.1.

Contributed by fred bregar.

Revision 13404
Added by Toshi MARUYAMA about 3 years ago

stricter check of uploading attachments (#17581)

Contributed by fred bregar.

Revision 13405
Added by Toshi MARUYAMA about 3 years ago

Merged r13404 from trunk to 2.5-stable (#17581)

stricter check of uploading attachments.

Contributed by fred bregar.

Revision 13406
Added by Toshi MARUYAMA about 3 years ago

Merged r13404 from trunk to 2.4-stable (#17581)

stricter check of uploading attachments.

Contributed by fred bregar.

History

#1 Updated by Toshi MARUYAMA over 3 years ago

  • Category set to Attachments
  • Target version set to 2.4.7

#2 Updated by Toshi MARUYAMA over 3 years ago

  • Related to Defect #13932: File upload does not work with Safari added

#3 Updated by Etienne Massip about 3 years ago

Why remove the 'FileReader' in window test?

#4 Updated by Toshi MARUYAMA about 3 years ago

Etienne Massip wrote:

Why remove the 'FileReader' in window test?

fred, could you give us the answer?

#5 Updated by fred bregar about 3 years ago

FileReader is not needed. (Search repo for FileReader)

Checking for FileReader was simply a hack for Safari 5.1 to return false. FileReader is for actually reading a file in a browser (like dragging a text file into the browser and creating a <textarea> tag and displaying contents of the file). Redmine is not reading the contents of the File, just uploading it.

a better test would be:

if ($.ajaxSettings.xhr().upload && inputEl.files)
//but this instantiates a new XMLHttpRequest object and does nothing with it.

but like i said (#13932-13) the real problem is jQuery. jQuery was amazing, but unless you need to support IE8 and below there is really no need for it these days.

#6 Updated by Toshi MARUYAMA about 3 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Committed in trunk, 2.5-stable and 2.4-stable, thanks.

Also available in: Atom PDF