Redmine

Why remove the 'FileReader' in window test?

Etienne Massip wrote:

Why remove the 'FileReader' in window test?

fred, could you give us the answer?

FileReader is not needed. (Search repo for FileReader)

Checking for FileReader was simply a hack for Safari 5.1 to return false. FileReader is for actually reading a file in a browser (like dragging a text file into the browser and creating a <textarea> tag and displaying contents of the file). Redmine is not reading the contents of the File, just uploading it.

a better test would be:

if ($.ajaxSettings.xhr().upload && inputEl.files)
//but this instantiates a new XMLHttpRequest object and does nothing with it.

but like i said (#13932-13) the real problem is jQuery. jQuery was amazing, but unless you need to support IE8 and below there is really no need for it these days.