Project

General

Profile

Actions

Defect #18499

closed

Localisation not set correctly on authenticity token errors

Added by Felix Schäfer over 9 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Normal
Category:
I18n
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Files

18499.patch (1.28 KB) 18499.patch Felix Schäfer, 2014-11-29 14:03
Actions #1

Updated by Felix Schäfer over 9 years ago

This error was discovered on Planio. The attached patch fixes the problem and adds a test to make sure it stays that way.

Maybe set_localization should even be called at the end of logged_user= to make sure a user change also changes the locale? (I haven't tested that though).

Actions #2

Updated by Jean-Philippe Lang over 9 years ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version set to 2.6.1
  • Resolution set to Fixed

Patch committed in r13670, thanks.

Felix Schäfer wrote:

Maybe set_localization should even be called at the end of logged_user= to make sure a user change also changes the locale? (I haven't tested that though).

Not sure it would improve things, most #logged_user= are followed by a redirect. And #set_localization would still have to be called in a few places.

Actions #3

Updated by Felix Schäfer over 9 years ago

Thanks for the quick merge!

Actions #4

Updated by Denis Savitskiy over 9 years ago

Pity, it doesn't help in 2.6.0develop

Actions #5

Updated by Jean-Philippe Lang about 9 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF