Actions
Defect #18499
closedLocalisation not set correctly on authenticity token errors
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Files
      
      Updated by Felix Schäfer almost 11 years ago
      
    
    - File 18499.patch 18499.patch added
 
This error was discovered on Planio. The attached patch fixes the problem and adds a test to make sure it stays that way.
Maybe set_localization should even be called at the end of logged_user= to make sure a user change also changes the locale? (I haven't tested that though).
      
      Updated by Jean-Philippe Lang almost 11 years ago
      
    
    - Status changed from New to Resolved
 - Assignee set to Jean-Philippe Lang
 - Target version set to 2.6.1
 - Resolution set to Fixed
 
Patch committed in r13670, thanks.
Felix Schäfer wrote:
Maybe
set_localizationshould even be called at the end oflogged_user=to make sure a user change also changes the locale? (I haven't tested that though).
Not sure it would improve things, most #logged_user= are followed by a redirect. And #set_localization would still have to be called in a few places.
      
      Updated by Denis Savitskiy almost 11 years ago
      
    
    Pity, it doesn't help in 2.6.0develop
      
      Updated by Jean-Philippe Lang almost 11 years ago
      
    
    - Status changed from Resolved to Closed
 
Actions